Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim some fat! 🥗 #525

Closed
alexreardon opened this issue May 27, 2018 · 12 comments
Closed

Trim some fat! 🥗 #525

alexreardon opened this issue May 27, 2018 · 12 comments

Comments

@alexreardon
Copy link
Collaborator

alexreardon commented May 27, 2018

There are some simple things we can do as a part of our build to hopefully drop some significant KB weight.

  • babel-plugin-dev-expression: remove all of our invariant message from production builds. Related: move all console.error expressions and move to invariant for consistent error handling (doing as a part of Major state refactor #493)
  • prepack try to reduce some functions into their static results
  • investigate our uglify options and see if there are any other approaches we can take advantage of
@TrySound
Copy link
Contributor

I could take a look after major state refactor merge

@TrySound
Copy link
Contributor

Do we have any components which can be unused in some cases?

@alexreardon
Copy link
Collaborator Author

alexreardon commented May 27, 2018 via email

@alexreardon
Copy link
Collaborator Author

Hey @TrySound, I almost have a stable branch that this work can start on. Are you keen to pick it up?

@alexreardon
Copy link
Collaborator Author

No pressure though, I am okay to do it too. I just wanted to give you the opportunity if you would like too!

@TrySound
Copy link
Contributor

I'll take a look

@alexreardon
Copy link
Collaborator Author

alexreardon commented Jun 22, 2018

okay sure, the branch is the major-state-refactor dev

@alexreardon
Copy link
Collaborator Author

it is green now, and should stay mostly intact

@alexreardon
Copy link
Collaborator Author

it also has a lot of bumped dependencies

@alexreardon
Copy link
Collaborator Author

alexreardon commented Jun 22, 2018

Actually, I have created a new branch dev which now has the latest. Can you please start that @TrySound ?

@enapupe enapupe mentioned this issue Jun 22, 2018
@alexreardon
Copy link
Collaborator Author

@TrySound I have bumped the rollup dependencies and it looks like the uglify plugin and your size plugin are no longer working. Feel free to roll them back to a stable version.

@TrySound TrySound mentioned this issue Jun 28, 2018
@alexreardon
Copy link
Collaborator Author

Shipped in version 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants