-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim some fat! 🥗 #525
Comments
I could take a look after major state refactor merge |
Do we have any components which can be unused in some cases? |
No 😊
…On Sun, 27 May 2018 at 10:45 pm, Bogdan Chadkin ***@***.***> wrote:
Do we have any components which can be unused in some cases?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#525 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACFN7Wzw5q_DpVwuPxFXR_9BDNnjNkmNks5t2qABgaJpZM4UPO31>
.
|
Hey @TrySound, I almost have a stable branch that this work can start on. Are you keen to pick it up? |
No pressure though, I am okay to do it too. I just wanted to give you the opportunity if you would like too! |
I'll take a look |
okay sure, the branch is the |
it is green now, and should stay mostly intact |
it also has a lot of bumped dependencies |
Actually, I have created a new branch |
@TrySound I have bumped the rollup dependencies and it looks like the uglify plugin and your size plugin are no longer working. Feel free to roll them back to a stable version. |
Shipped in version 9 |
There are some simple things we can do as a part of our build to hopefully drop some significant KB weight.
invariant
message from production builds. Related: move all console.error expressions and move to invariant for consistent error handling (doing as a part of Major state refactor #493)The text was updated successfully, but these errors were encountered: