Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad performance when unloading resource contents #61

Closed
sunye opened this issue Jan 25, 2017 · 2 comments
Closed

Bad performance when unloading resource contents #61

sunye opened this issue Jan 25, 2017 · 2 comments
Labels
Component: Core Status: Completed
Milestone
Release 2.0.0

Comments

@sunye
Copy link
Contributor

sunye commented Jan 25, 2017

Method Resource::unload() seems to call the indexOf() method for persistent referenced, generating an important overload.
@yvrng yvrng mentioned this issue Jun 7, 2017
Closed
@yvrng yvrng added this to the Release 1.1.0 milestone Jun 24, 2017
@yvrng
Copy link
Contributor

yvrng commented Sep 15, 2017

This may be related to the ResourceImpl#getUnloadingContents() method that creates a full copy of the resource's content, to define the proxy and clear the adapters for each object (if supported) with theResourceImpl#unloaded(InternalEObject) method.

yvrng added a commit that referenced this issue Sep 20, 2017
@yvrng
fix issues #62 & #61: improve resource unloading & attachment
c253e64
@yvrng
Copy link
Contributor

yvrng commented Sep 20, 2017

PersistentEObjects are created on demand, so the call to ResourceImpl#getUnloadingContents() when unloading is not relevant. This method now returns a Collections.emptyList() as specified in the method description.

@yvrng yvrng closed this as completed Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Core Status: Completed
Projects
None yet
Milestone
Release 2.0.0
Development

No branches or pull requests
2 participants
@sunye @yvrng