Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transient store creation on resource shutdown? #27

Closed
gdaniel opened this issue May 9, 2016 · 2 comments
Closed

Remove transient store creation on resource shutdown? #27

gdaniel opened this issue May 9, 2016 · 2 comments

Comments

@gdaniel
Copy link
Contributor

gdaniel commented May 9, 2016

Creating a transient store / backend on resource shutdown consumes memory and may be problematic for the maven build, where all the tests are executed in the same JVM, creating many transient (and useless) stores.

@yvrng
Copy link
Contributor

yvrng commented Mar 22, 2017

It's a strange behavior, because the transient Store created when closing is empty. The problem may comes from elsewhere.

We should perhaps create a ClosedStoreDecorator to avoid changes to a closed Resource ?

@yvrng yvrng added this to the Release 1.1.0 milestone Mar 22, 2017
@yvrng
Copy link
Contributor

yvrng commented Jun 7, 2017

Fixed in #69: A Store is no longer copied when the associated Resource is unloading: a Resource should not be called if it's not loaded.

This can also help for issue #61.

@yvrng yvrng modified the milestone: Release 1.1.0 Jun 9, 2017
@yvrng yvrng closed this as completed Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants