Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rubygems_mfa_required setting and disable RequireMFA cop #620

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Remove rubygems_mfa_required setting and disable RequireMFA cop #620

merged 5 commits into from
Jul 12, 2024

Commits on Jul 12, 2024

  1. Remove rubygems_mfa_required setting and disable RequireMFA cop 

    This setting was introduced automatically by the aforementioned rubocop cop,which makes it impossible to publish to rubygems automatically from a Githubaction with an API key, since one would always need the second factor.
    @ayushpoddar
    ayushpoddar committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e55bcba View commit details
    Browse the repository at this point in the history

  2. Disable codecov 

    The uploader was deprecated and is no longer working.

There is a new uploader that should be used instead: https://docs.codecov.com/docs/codecov-uploader
    @avdv
    avdv committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c8a0401 View commit details
    Browse the repository at this point in the history

  3. Set permissions for release drafter workflow

    @avdv
    avdv committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0739649 View commit details
    Browse the repository at this point in the history

  4. Upgrade release-drafter to v6

    @avdv
    avdv committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6f7dedc View commit details
    Browse the repository at this point in the history

  5. Disable Windows CI jobs 

    They fail with:

```
D:/a/colorls/colorls/vendor/bundle/ruby/3.0.0/gems/hpricot-0.8.6/ext/fast_xs
make.exe DESTDIR\=
generating fast_xs-x64-mingw32.def
compiling fast_xs.c
fast_xs.c: In function 'fast_xs':
fast_xs.c:165:46: error: passing argument 3 of 'rb_rescue' from incompatible
pointer type [-Wincompatible-pointer-types]
  165 |         array = rb_rescue(unpack_utf8, self, unpack_uchar, self);
      |                                              ^~~~~~~~~~~~
      |                                              |
|                                              VALUE (*)(VALUE) {aka long
long unsigned int (*)(long long unsigned int)}
```
    @avdv
    avdv committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0b7b88c View commit details
    Browse the repository at this point in the history