Remove rubygems_mfa_required setting and disable RequireMFA cop
#620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting was introduced automatically by the aforementioned rubocop cop,which makes it impossible to publish to rubygems automatically from a Githubaction with an API key, since one would always need the second factor.
5 tasks
The uploader was deprecated and is no longer working. There is a new uploader that should be used instead: https://docs.codecov.com/docs/codecov-uploader
avdv
force-pushed
the
disable-mfa-duplicate
branch
from
e6b86c5
to
c8a0401
Compare
|
Thank you @ayushpoddar ! It seems this repo has bit rotted quite a bit as CI is failing for the changes. I have disabled the codecov upload for now. Also, the Windows builds are failing because of hpricot which was abandoned. I'll disable the Windows CI jobs for now. |
They fail with:
```
D:/a/colorls/colorls/vendor/bundle/ruby/3.0.0/gems/hpricot-0.8.6/ext/fast_xs
make.exe DESTDIR\=
generating fast_xs-x64-mingw32.def
compiling fast_xs.c
fast_xs.c: In function 'fast_xs':
fast_xs.c:165:46: error: passing argument 3 of 'rb_rescue' from incompatible
pointer type [-Wincompatible-pointer-types]
165 | array = rb_rescue(unpack_utf8, self, unpack_uchar, self);
| ^~~~~~~~~~~~
| |
| VALUE (*)(VALUE) {aka long
long unsigned int (*)(long long unsigned int)}
```
@avdv Does this mean that we can merge the pending PRs one by one? |
yes, but I am going to be AFK for some time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting was introduced automatically by the aforementioned rubocop cop, which makes it impossible to publish to rubygems automatically from a Github action with an API key, since one would always need the second factor.
Description
This PR is a copy of the linked PR below.
rubygems_mfa_requiredsetting and disable RequireMFA cop #596