Extend validation to assert specific response text #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per @stmoody's report in the `rveachkc/pymsteams` project, Microsoft Teams webhook endpoint(s) will return a 200 status response code in some scenarios when a message was actually (seemingly silently) rejected due to size limits. Microsoft Teams developers shared that a response string of `1` must be present alongside a 200 status response code to indicate successful message submission by the client. This commit extends response validation to check for the presence of this specific response string, otherwise returns a custom error along with a description of what was expected and what was actually received. refs rveachkc/pymsteams#75 refs GH-59
Current tests fail with prior change, pass now with updated response text to match updated validation requirement. refs GH-59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per
stmoody's report in therveachkc/pymsteamsproject, Microsoft Teams webhook endpoint(s) will return a 200 status response code in some scenarios when a message was actually (seemingly silently) rejected due to size limits. Microsoft Teams developers shared that a response string of1must be present alongside a 200 status response code to indicate successful message submission by the client.This commit extends response validation to check for the presence of this specific response string, otherwise returns a custom error along with a description of what was expected and what was actually received.