forked from dasrick/go-teams-notify
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft Teams Webhook Connector "200 OK" status insufficient indication of success #59
Comments
atc0005
added a commit
that referenced
this issue
Jan 28, 2021
Per @stmoody's report in the `rveachkc/pymsteams` project, Microsoft Teams webhook endpoint(s) will return a 200 status response code in some scenarios when a message was actually (seemingly silently) rejected due to size limits. Microsoft Teams developers shared that a response string of `1` must be present alongside a 200 status response code to indicate successful message submission by the client. This commit extends response validation to check for the presence of this specific response string, otherwise returns a custom error along with a description of what was expected and what was actually received. refs rveachkc/pymsteams#75 refs GH-59
atc0005
added a commit
that referenced
this issue
Jan 28, 2021
Per @stmoody's report in the `rveachkc/pymsteams` project, Microsoft Teams webhook endpoint(s) will return a 200 status response code in some scenarios when a message was actually (seemingly silently) rejected due to size limits. Microsoft Teams developers shared that a response string of `1` must be present alongside a 200 status response code to indicate successful message submission by the client. This commit extends response validation to check for the presence of this specific response string, otherwise returns a custom error along with a description of what was expected and what was actually received. refs rveachkc/pymsteams#75 refs GH-59
atc0005
added a commit
that referenced
this issue
Jan 28, 2021
Current tests fail with prior change, pass now with updated response text to match updated validation requirement. refs GH-59
atc0005
added a commit
that referenced
this issue
Jul 12, 2024
- lower `AdaptiveCardMaxVersion` from `1.5` to `1.4` - this almost seems like a bug on Teams' end as this limitation is not communicated (from what I could tell) via https://adaptivecards.io/designer/ - using a value of `1.4` appears to work equally well for O365 and Workflow connectors - treat a 202 response code as sufficient response verification - instead of expecting a `1` in the response body as previously confirmed - see also #59 - add `logic.azure.com` to valid URL patterns for default validation - debugging / troubleshooting - log status code and response string for O365 connector responses - log validation pattern match refs GH-262
atc0005
added a commit
that referenced
this issue
Jul 24, 2024
- lower `AdaptiveCardMaxVersion` from `1.5` to `1.4` - this almost seems like a bug on Teams' end as this limitation is not communicated (from what I could tell) via https://adaptivecards.io/designer/ - using a value of `1.4` appears to work equally well for O365 and Workflow connectors - treat a 202 response code as sufficient response verification - instead of expecting a `1` in the response body as previously confirmed - see also #59 - add `logic.azure.com` to valid URL patterns for default validation - debugging / troubleshooting - log status code and response string for O365 connector responses - log validation pattern match refs GH-262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From rveachkc/pymsteams#75:
Needs further research/testing. Further notes from that GH issue:
So 20k+ characters is enough to hit a limit, but probably worth implementing the check as noted previously instead of trying to check for a specific hard-coded message size limit.
The text was updated successfully, but these errors were encountered: