Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand, update go-ci-stable-debian-build image #869

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Feb 17, 2023

The go-ci-stable-debian-build image was poorly named and
failed to convey the intended purpose:

Provide an image to support cross-platform, static cgo-enabled
builds for Windows and Linux.

This set of changes reworks the image to drop linting support
(which was always an afterthought) and rename it to
go-ci-stable-cgo-mingw-w64-build.

The README has been updated to remove the "Do you use this
image?" prompt and provide an overview that better reflects
the image's purpose.

NOTE: The previous steps to create a temporary copy of the
golangci-lint config file for each stable image being built
and then prune the temporary file as part of the dedicated
cleanup recipe and post-build cleanup have been removed.
The "stable" variant of the linting config file has been
moved directly into the stable/combined/ path.

fixes GH-657

The `go-ci-stable-debian-build` image was poorly named and
failed to convey the intended purpose:

Provide an image to support cross-platform, static cgo-enabled
builds for Windows and Linux.

This set of changes reworks the image to drop linting support
(which was always an afterthought) and rename it to
`go-ci-stable-cgo-mingw-w64-build`.

The README has been updated to remove the "Do you use this
image?" prompt and provide an overview that better reflects
the image's purpose.

NOTE: The previous steps to create a temporary copy of the
golangci-lint config file for each stable image being built
and then prune the temporary file as part of the dedicated
cleanup recipe and post-build cleanup have been removed.
The "stable" variant of the linting config file has been
moved directly into the stable/combined/ path.

refs GH-657
@atc0005 atc0005 added documentation Improvements or additions to documentation CI stable Makefile stable-build-only labels Feb 17, 2023
@atc0005 atc0005 added this to the Next Release milestone Feb 17, 2023
@atc0005 atc0005 self-assigned this Feb 17, 2023
@atc0005 atc0005 merged commit aaa91f6 into master Feb 17, 2023
@atc0005 atc0005 deleted the i657-rebrand-debian-build-image branch February 17, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI documentation Improvements or additions to documentation Makefile stable stable-build-only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discontinue go-ci-stable-debian-build container image?
1 participant