Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue go-ci-stable-debian-build container image? #657

Closed
atc0005 opened this issue Jun 19, 2022 · 7 comments · Fixed by #869
Closed

Discontinue go-ci-stable-debian-build container image? #657

atc0005 opened this issue Jun 19, 2022 · 7 comments · Fixed by #869
Assignees
Labels
question Further information is requested stable stable-build-only
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 19, 2022

While reviewing this image as part of #656 & #557 I realized that while the image continues to be maintained, I'm not sure that it is ever used.

https://github.com/atc0005/go-ci/pkgs/container/go-ci/23958027?tag=go-ci-stable-debian-build

It may have been used early on by the atc0005/mysql2sqlite project before switching over to Alpine images, but I'll need to dig back to confirm.

@atc0005 atc0005 added question Further information is requested stable stable-build-only labels Jun 19, 2022
@atc0005 atc0005 added this to the Future milestone Jun 19, 2022
@atc0005 atc0005 self-assigned this Jun 19, 2022
@atc0005 atc0005 pinned this issue Jun 19, 2022
@atc0005 atc0005 modified the milestones: Future, Next Release Aug 9, 2022
@atc0005
Copy link
Owner Author

atc0005 commented Aug 9, 2022

From the current README:

go-ci-stable-debian-build

  • built from the latest version of the current stable golang image.
  • used for building Go applications, both directly and via Makefile builds.
  • supports cross-platform, static cgo-enabled builds for Windows and Linux
    • Windows 32-bit: i686-w64-mingw32-gcc
    • Windows 64-bit: x86_64-w64-mingw32-gcc
  • provides multiple linters
    • see Linting tools included

Some additional context when deciding whether to keep it.

@atc0005 atc0005 unpinned this issue Aug 9, 2022
@atc0005
Copy link
Owner Author

atc0005 commented Feb 3, 2023

Looking over CI jobs and the mysql2sqlite Makefile, this image is not used.

Looking at older repos, I see where I originally used it in another CGO-enabled project. That project however is archived and I'm unlikely to work on it further.

In short, I'm not using this image. Instead, I'm using the ghcr.io/atc0005/go-ci:go-ci-stable-mirror-build repo/image for CI jobs (with needed packages installed within the image via APT).

@atc0005 atc0005 modified the milestones: Future, Next Release Feb 3, 2023
@atc0005
Copy link
Owner Author

atc0005 commented Feb 3, 2023

Dropped the Build stable Debian image using Makefile CI job requirement from branch protection (since we're dropping that image).

@atc0005
Copy link
Owner Author

atc0005 commented Feb 3, 2023

I spot-checked the download count for this image via https://github.com/atc0005/go-ci/pkgs/container/go-ci/versions and found that for recent versions:

  • go-ci-stable-debian-build-v0.7.8-0-g3468babf
  • go-ci-stable-debian-build-v0.7.7-0-g1462318b
  • go-ci-stable-debian-build-v0.7.6-0-g2817b397

no downloads are recorded.

For older images however, there are some downloads:

  • go-ci-stable-debian-build-v0.7.5-0-g41da41e [qty: 4]
  • ...
  • go-ci-stable-debian-build-v0.7.0-0-gf9532bf [qty: 2]

there are at least a few downloads of each. Some of the downloads may come from CI jobs for the archived repo/project I mentioned previously. Not sure about the others.

Perhaps I'll hold off a little longer retiring this image. Will plan to revisit this in say, six months from now to see what the download counts show.

@atc0005
Copy link
Owner Author

atc0005 commented Feb 3, 2023

FWIW, Docker Hub shows 0 downloads for v0.7.6 and newer versions of the image. This includes the atc0005/go-ci:go-ci-stable-debian-build tag.

atc0005 added a commit that referenced this issue Feb 3, 2023
Link to current GH issue asking for feedback.

refs GH-657
@atc0005
Copy link
Owner Author

atc0005 commented Feb 3, 2023

Dropped the Build stable Debian image using Makefile CI job requirement from branch protection (since we're dropping that image).

Added it back for now.

@atc0005
Copy link
Owner Author

atc0005 commented Feb 3, 2023

I stored a WIP PR branch that drops the image for later consideration/use.

@atc0005 atc0005 pinned this issue Feb 3, 2023
@atc0005 atc0005 modified the milestones: Next Release, Future Feb 3, 2023
@atc0005 atc0005 modified the milestones: Future, Next Release Feb 17, 2023
atc0005 added a commit that referenced this issue Feb 17, 2023
The `go-ci-stable-debian-build` image was poorly named and
failed to convey the intended purpose:

Provide an image to support cross-platform, static cgo-enabled
builds for Windows and Linux.

This set of changes reworks the image to drop linting support
(which was always an afterthought) and rename it to
`go-ci-stable-cgo-mingw-w64-build`.

The README has been updated to remove the "Do you use this
image?" prompt and provide an overview that better reflects
the image's purpose.

refs GH-657
atc0005 added a commit that referenced this issue Feb 17, 2023
The `go-ci-stable-debian-build` image was poorly named and
failed to convey the intended purpose:

Provide an image to support cross-platform, static cgo-enabled
builds for Windows and Linux.

This set of changes reworks the image to drop linting support
(which was always an afterthought) and rename it to
`go-ci-stable-cgo-mingw-w64-build`.

The README has been updated to remove the "Do you use this
image?" prompt and provide an overview that better reflects
the image's purpose.

refs GH-657
atc0005 added a commit that referenced this issue Feb 17, 2023
The `go-ci-stable-debian-build` image was poorly named and
failed to convey the intended purpose:

Provide an image to support cross-platform, static cgo-enabled
builds for Windows and Linux.

This set of changes reworks the image to drop linting support
(which was always an afterthought) and rename it to
`go-ci-stable-cgo-mingw-w64-build`.

The README has been updated to remove the "Do you use this
image?" prompt and provide an overview that better reflects
the image's purpose.

NOTE: The previous steps to create a temporary copy of the
golangci-lint config file for each stable image being built
and then prune the temporary file as part of the dedicated
cleanup recipe and post-build cleanup have been removed.
The "stable" variant of the linting config file has been
moved directly into the stable/combined/ path.

refs GH-657
@atc0005 atc0005 unpinned this issue Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested stable stable-build-only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant