Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct workflows and pom files #247

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Correct workflows and pom files #247

merged 2 commits into from
Feb 27, 2024

Conversation

mirromutth
Copy link
Contributor

Motivation:

Fix #246

Modification:

  • Remove parent/child relationship
  • Specify tag name formatting
  • Correct workflows of GitHub Actions

Result:

Corrected workflows and pom files

@mirromutth mirromutth added the bug Something isn't working label Feb 27, 2024
@mirromutth mirromutth added this to the 1.1.2 milestone Feb 27, 2024
@mirromutth mirromutth self-assigned this Feb 27, 2024
@mirromutth mirromutth linked an issue Feb 27, 2024 that may be closed by this pull request
[bug] Deploy broken #246
Closed
jchrys
jchrys approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirromutth mirromutth merged commit 5954865 into trunk Feb 27, 2024
15 checks passed
@mirromutth mirromutth deleted the 246-bug-deploy-broken branch February 27, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchrys jchrys jchrys approved these changes

Assignees

@mirromutth mirromutth

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

[bug] Deploy broken
2 participants
@mirromutth @jchrys