Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Deploy broken #246

Closed
mirromutth opened this issue Feb 26, 2024 · 3 comments · Fixed by #247
Closed

[bug] Deploy broken #246

mirromutth opened this issue Feb 26, 2024 · 3 comments · Fixed by #247
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mirromutth
Copy link
Contributor

Describe the bug

  1. Unexpected tag formatting r2dbc-mysql-parent-${version}
  2. Missing publish of r2dbc-mysql-parent

Import 1.1.2-SNAPSHOT, Gradle reports:

Execution failed for task ':compileJava'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not resolve io.asyncer:r2dbc-mysql:1.1.2-SNAPSHOT.
     Required by:
         project :
      > Could not resolve io.asyncer:r2dbc-mysql:1.1.2-SNAPSHOT.
         > Could not parse POM https://s01.oss.sonatype.org/content/repositories/snapshots/io/asyncer/r2dbc-mysql/1.1.2-SNAPSHOT/r2dbc-mysql-1.1.2-20240222.165350-14.pom
            > Could not find io.asyncer:r2dbc-mysql-parent:1.1.2-SNAPSHOT.

To Reproduce
Steps to reproduce the behavior:

  1. Run RELEASE action.
  2. Import repository r2dbc-mysql:1.1.2-SNPAHOT

Expected behavior

  1. Tag should be r2dbc-mysql-${version} or v${version}. Use maven-release-plugin configuration fixes it
  2. Add r2dbc-mysql-parent deploying in action workflow

Additional context

It should be caused by #239

@mirromutth mirromutth added the bug Something isn't working label Feb 26, 2024
@mirromutth mirromutth added this to the 1.1.2 milestone Feb 26, 2024
@mirromutth mirromutth self-assigned this Feb 26, 2024
@mirromutth
Copy link
Contributor Author

@jchrys I'll force push to undo bot commits and remove the unexpected tag.

@jchrys
Copy link
Collaborator

jchrys commented Feb 26, 2024

Describe the bug

  1. Unexpected tag formatting r2dbc-mysql-parent-${version}

  2. Missing publish of r2dbc-mysql-parent

Import 1.1.2-SNAPSHOT, Gradle reports:


Execution failed for task ':compileJava'.

> Could not resolve all files for configuration ':compileClasspath'.

   > Could not resolve io.asyncer:r2dbc-mysql:1.1.2-SNAPSHOT.

     Required by:

         project :

      > Could not resolve io.asyncer:r2dbc-mysql:1.1.2-SNAPSHOT.

         > Could not parse POM https://s01.oss.sonatype.org/content/repositories/snapshots/io/asyncer/r2dbc-mysql/1.1.2-SNAPSHOT/r2dbc-mysql-1.1.2-20240222.165350-14.pom

            > Could not find io.asyncer:r2dbc-mysql-parent:1.1.2-SNAPSHOT.

To Reproduce

Steps to reproduce the behavior:

  1. Run RELEASE action.

  2. Import repository r2dbc-mysql:1.1.2-SNPAHOT

Expected behavior

  1. Tag should be r2dbc-mysql-${version} or v${version}. Use maven-release-plugin configuration fixes it

  2. Add r2dbc-mysql-parent deploying in action workflow

Additional context

It should be caused by #239

Thanks!

(I guess we might need to remove parent dependency from r2dbc-mysql module xml. By doing that I think we could prevent the parent artifact from being deployed as a r2dbc-mysql's dependency)

@mirromutth
Copy link
Contributor Author

Yep, you are right. At least for now, we do not need a parent module unless we are going to implement r2dbc-mysql-extension-jackson or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants