Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote identifier support #199

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Add quote identifier support #199

merged 1 commit into from
Jan 15, 2024

Conversation

mirromutth
Copy link
Contributor

@mirromutth mirromutth commented Jan 15, 2024

Motivation:

Support backticks in savepoint/database/table/column names.

See also #198 .

Modification:

Add StringUtils#quoteIdentifier and AssertUtils#requireNonEmpty for all identifier names.

Add dependency junit-jupiter-params to simplify test cases.

Remove AssertUtils#requireValidName.

Result:

User can use backticks in identifier name.

@mirromutth mirromutth added the enhancement New feature or request label Jan 15, 2024
@mirromutth mirromutth linked an issue Jan 15, 2024 that may be closed by this pull request
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchrys jchrys added this to the 1.0.7/0.9.8 milestone Jan 15, 2024
@mirromutth mirromutth merged commit e01335f into trunk Jan 15, 2024
12 checks passed
@mirromutth mirromutth deleted the feature/issues-198 branch January 15, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support backticks in column/table/database/savepoint name
2 participants