Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Support backticks in column/table/database/savepoint name #198

Closed
mirromutth opened this issue Jan 15, 2024 · 0 comments · Fixed by #199
Closed

[feature] Support backticks in column/table/database/savepoint name #198

mirromutth opened this issue Jan 15, 2024 · 0 comments · Fixed by #199
Assignees
@mirromutth
Labels
enhancement New feature or request
Milestone
1.1.0

Comments

@mirromutth
Copy link
Contributor

Is your feature request related to a problem? Please describe.

MySQL/MariaDB actually support backticks in names, escaping with two backticks:

CREATE DATABASE `bad``name`

Describe the solution you'd like

Remove requireValidName check and add backtick escape support in names.
@mirromutth mirromutth added the enhancement New feature or request label Jan 15, 2024
@mirromutth mirromutth self-assigned this Jan 15, 2024
@mirromutth mirromutth mentioned this issue Jan 15, 2024
Merged
@mirromutth mirromutth linked a pull request Jan 15, 2024 that will close this issue
Add quote identifier support #199
Merged
@jchrys jchrys added this to the 1.1.0/0.10.0 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirromutth mirromutth

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Add quote identifier support asyncer-io/r2dbc-mysql
2 participants
@mirromutth @jchrys