-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: removed the faulty release file and it's redirects #689
Conversation
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-689--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pratik2315 it looks like you have to resolve some conflicts in the _redirects
file. Once you do that, this looks good to go :)
@pratik2315 @alequetzalli I helped solving conflict. It happened because yesterday we released RC 4 for the 2.4 spec and new redirect was added, line about what @pratik2315 changed, thus conflict appeared |
Damn thanks a lot!! I was confused for a while about what exactly went wrong😅 |
There was one more merge conflict, 2.4 related 😅 solved |
@alequetzalli you can approve now 😄 |
Description
Related issue(s)
Fixes #688