Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removed the faulty release file and it's redirects #689

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

pratik9315
Copy link
Contributor

Description

Related issue(s)
Fixes #688

@netlify
Copy link

netlify bot commented Apr 25, 2022

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 241b602
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/626a788ccb80c50008de3af0
😎 Deploy Preview https://deploy-preview-689--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@derberg derberg changed the title chore: removed the faulty release file and it's redirects docs: removed the faulty release file and it's redirects Apr 25, 2022
derberg
derberg previously approved these changes Apr 25, 2022
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@github-actions
Copy link

github-actions bot commented Apr 25, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 51
🟠 Accessibility 75
🟠 Best practices 83
🟢 SEO 90
🔴 PWA 30

Lighthouse ran on https://deploy-preview-689--asyncapi-website.netlify.app/

@quetzalliwrites quetzalliwrites added 🐞 docs bug area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Apr 26, 2022
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratik2315 it looks like you have to resolve some conflicts in the _redirects file. Once you do that, this looks good to go :)

@derberg
Copy link
Member

derberg commented Apr 27, 2022

@pratik2315 @alequetzalli I helped solving conflict. It happened because yesterday we released RC 4 for the 2.4 spec and new redirect was added, line about what @pratik2315 changed, thus conflict appeared

derberg
derberg previously approved these changes Apr 27, 2022
@pratik9315
Copy link
Contributor Author

pratik9315 commented Apr 27, 2022

@pratik2315 @alequetzalli I helped solving conflict. It happened because yesterday we released RC 4 for the 2.4 spec and new redirect was added, line about what @pratik2315 changed, thus conflict appeared

Damn thanks a lot!! I was confused for a while about what exactly went wrong😅

@derberg
Copy link
Member

derberg commented Apr 27, 2022

There was one more merge conflict, 2.4 related 😅 solved

@derberg
Copy link
Member

derberg commented Apr 27, 2022

@alequetzalli you can approve now 😄

@derberg derberg merged commit c291359 into asyncapi:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 🐞 docs bug
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Feedback on /docs/specifications/v2.3.1-2022-04-release.1 - Mon, 25 Apr 2022 13:30:59 GMT
3 participants