-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken link to generator github actions #3191
fix: broken link to generator github actions #3191
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3191--asyncapi-website.netlify.app/ |
Hi @lucky29-git there's already PR opened solving the same #3071 |
@DhairyaMajmudar Oh I see, btw the file changed in #3071 is edit-page-config.json which is different from the 3 files I changed. |
Yeah, correct so this PR is trying to update the internal non-working links, no need revoke it, wait until maintainers review and merge it : ) |
@sambhavgupta0705 can you please review this too? |
@quetzalliwrites @TRohit20 please take a look |
closing this as duplicate #3217 |
Hey @sambhavgupta0705, I opened this PR three weeks ago, but it looks like a newer PR got merged instead. 😞 No worries, though! |
Description
There is a broken link in the AsyncAPI Generator Installation Guide (https://www.asyncapi.com/docs/tools/generator/installation-guide#uninstall-asyncapi-cli) that needs to be updated.
Current Link: https://github.com/marketplace/actions/generator-for-asyncapi-documents
Correct Link: https://github.com/marketplace/actions/generator-validator-converter-and-others-all-in-one-for-your-asyncapi-docs
Related issue(s) Resolve #3190