-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(link): fixing github redirecting links #3071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@akshatnema dunno why Lighthouse CI is failing even for small change is there any way to fix ? |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3071--asyncapi-website.netlify.app/ |
Thanks for the change, @DhairyaMajmudar. Can you please dig into the issue further as I just found out some other docs edit links are broken. For example: https://www.asyncapi.com/docs/tools/generator/asyncapi-document link should have an edit link to https://github.com/asyncapi/generator/blob/master/apps/generator/docs/asyncapi-document.md but is instead https://github.com/asyncapi/generator/tree/master/docs/asyncapi-document.mdx which is wrong. |
Sure thing 👍🏻 |
@DhairyaMajmudar just check all the links and report them here after that have we can see that need to change only the config or the gh action ferentor ' |
Hi, @anshgoyalevil @sambhavgupta0705 I checked the links and did the needy changes in config files but the bug still exists since the links generated redirects to The reason behind is their declaration in the EDIT: Also its a bit strange how I'm able to access the files mentioned in .gitignore |
@sambhavgupta0705 just a friendly ping on this. |
@derberg we need your suggestion here |
you also need to update the component responsible for edit link: https://github.com/asyncapi/website/blob/master/components/layout/DocsLayout.tsx#L53 |
@DhairyaMajmudar any updates on the PR? |
I'm still unsure of this #3071 (comment) |
@akshatnema @sambhavgupta0705 I've fixed the problem stated in #3071 (comment) now links are working as expected, can you pls. review the PR. |
add config for glee docs |
closing this one as we have changed the scope of the issue |
Description
edit-page-config.json
file to fix the issuepage
in the href key tomarkdown
Related issue(s)
Fixes #3067