Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eslint npm scripts and convert eslintrc.js to eslintrc.json #1647

Closed
wants to merge 3 commits into from

Conversation

anshgoyalevil
Copy link
Member

Description
This PR does the following things:

  • Update eslint plugin
  • Add lint:fix and lint:check npm scripts
  • Convert .eslintrc.js to .eslintrc.json

Related issue(s)

This PR fixes #1639

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2fe2e2f
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/649441cfdca8d10008fd1e84
😎 Deploy Preview https://deploy-preview-1647--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 11, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 22
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1647--asyncapi-website.netlify.app/

package.json Outdated Show resolved Hide resolved
@anshgoyalevil
Copy link
Member Author

anshgoyalevil commented Jun 22, 2023

@derberg I would suggest shifting from a separate configuration of eslint for every project to a separate plugin specially for AsyncAPI.

More like globalizing the rules across the organization.

I created a plugin for AsyncAPI projects. Could you please check if its appropriate? https://github.com/anshgoyalevil/eslint-config

Issue Link: asyncapi/community#238

@derberg
Copy link
Member

derberg commented Jun 22, 2023

@anshgoyalevil yeah, we should do that, we have too many copy/paste around the whole initiative. Of course some folks could do their own config, but if not, then they could use this package.

@anshgoyalevil
Copy link
Member Author

@derberg Should we shift it under the @asyncapi/eslint-config npm package?

Copy link
Member

derberg commented Jun 27, 2023

yeah, let's first try your package through your account and see it in action and then we can ask community to accept your project

@akshatnema
Copy link
Member

@anshgoyalevil @derberg Closing this PR as we are moving with #1946.

@akshatnema akshatnema closed this Jul 21, 2023
@anshgoyalevil anshgoyalevil deleted the eslint-fix branch September 8, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert .eslintrc.js from Common JS Module to ES Module
3 participants