-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add eslint npm scripts and convert eslintrc.js to eslintrc.json #1647
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1647--asyncapi-website.netlify.app/ |
Co-authored-by: Lukasz Gornicki <[email protected]>
@derberg I would suggest shifting from a separate configuration of eslint for every project to a separate plugin specially for AsyncAPI. More like globalizing the rules across the organization. I created a plugin for AsyncAPI projects. Could you please check if its appropriate? https://github.com/anshgoyalevil/eslint-config Issue Link: asyncapi/community#238 |
@anshgoyalevil yeah, we should do that, we have too many copy/paste around the whole initiative. Of course some folks could do their own config, but if not, then they could use this package. |
@derberg Should we shift it under the |
yeah, let's first try your package through your account and see it in action and then we can ask community to accept your project |
@anshgoyalevil @derberg Closing this PR as we are moving with #1946. |
Description
This PR does the following things:
lint:fix
andlint:check
npm scriptsRelated issue(s)
This PR fixes #1639