Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create eslint plugin for organization repositories #238

Closed
magicmatatjahu opened this issue Jan 19, 2022 · 19 comments
Closed

Create eslint plugin for organization repositories #238

magicmatatjahu opened this issue Jan 19, 2022 · 19 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Jan 19, 2022

Before contribution please start discussion to clarify implementation and your questions/problems :)

This problem is involved in the OpenForce event. Please don't contribute if you are not participating in this event. If the problem is not solved at the end of the event, feel free to contribute :)

As our organization is expanding and we are creating/migrating more repositories, some of them also require eslint integration.

This is problematic because we have to copy the config file from our other repository each time. We should go in the direction of one configuration that we can override, something like the @asyncapi/eslint-plugin package. The config itself should support both JS and TS and should extend plugins like:

  • sonarjs
  • security
  • react
  • jest/mocha (depending on which test framework is used in the repo)

We can model ourselves on the airbnb plugin how to do that - https://github.com/airbnb/javascript

@MitAbhay
Copy link

MitAbhay commented Mar 5, 2022

I am OpenForce 2022 contributor and interested to work on this issue, so can you please tell me some of the prerequisites to solve this issue, so that I can decide if this is for me or not?

@magicmatatjahu
Copy link
Member Author

@MitAbhay Hi! Yeah, sure, no problem:

  • we need to create eslint configuration that we will be able to use in other packages, so it should be published to the npm like airbnb done https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb-base
  • we should base that config on one of the ours config - modelina would be good https://github.com/asyncapi/modelina/blob/master/.eslintrc
  • we need to support JS as well TS (we have to support both languages)
  • we need to support plugins for sonarjs security
  • for react and jest/mocha probably we need second eslint plugin because I don't know how to "switch off" given presets from plugin - when we don't use React/Jest in project we don't need given rules, yes?
  • after writing plugin we need to test it in one of our repos (modelina or studio would be good).

That's it for now. Remember that just writing the config is easy, but the rest of things like testing in repo etc is not (probably, I guess). Let us know if you like it or not :)

@vasantisuthar
Copy link

Hi, I am Vasanti Suthar. I am a contributor to OpenForce 2022, and I would like to work on this issue.

@vasantisuthar
Copy link

Hi, I am Vasanti Suthar. I am a contributor to OpenForce 2022, and I would like to work on this issue.

Please assign this to me

@magicmatatjahu
Copy link
Member Author

@vasantisuthar Sorry, I didn't notice the previous comment. Of course I can assign you, but @MitAbhay wanted to do it first. I don't know the ins and outs of OpenSource exactly, but according to me you can work together. As for the assignment itself, it would be best if you create your own repo first and then that repo will be moved to our org or @derberg should we create such a repo in our org now?

@derberg
Copy link
Member

derberg commented Mar 17, 2022

better work on your own repo @vasantisuthar and involve @magicmatatjahu in review and then we will bring it into the organization.

we need clear message who is working on it, please do not duplicate yourself we have other issues to.
@vasantisuthar @MitAbhay just tell us who of you is actively working on it

@MitAbhay
Copy link

@derberg Currently, I am not working on this.

@vasantisuthar
Copy link

@derberg I am working on it.

@vasantisuthar
Copy link

@derberg I want to inform you that, I will be not able to work on this issue as I have my exams right now, So I will not be able to complete this, before 28 March. Thank you.

@magicmatatjahu
Copy link
Member Author

@vasantisuthar No worries, thanks for info!

@derberg
Copy link
Member

derberg commented Apr 4, 2022

@vasantisuthar do you want to continue working on this one? I know OpenForce ended but if you are still interested and you were delayed by exams, we can still give you some time for this one

@vasantisuthar
Copy link

Sure, I want to work on this issue, I'll try to complete it as soon as possible. Thank you

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Aug 3, 2022
@magicmatatjahu
Copy link
Member Author

@vasantisuthar Are you still willing to do this task?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Apr 21, 2023
@anshgoyalevil
Copy link
Member

@magicmatatjahu

I would like to work upon this issue. Could you please assign it to me.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 8, 2023
@github-actions github-actions bot removed the stale label Oct 8, 2023
Copy link

github-actions bot commented Feb 6, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

6 participants
@derberg @magicmatatjahu @vasantisuthar @MitAbhay @anshgoyalevil and others