feat: implement sharing of document through netlify blobs #1135
Conversation
Shurtu-gal
requested review from
magicmatatjahu,
KhudaDad414,
Amzani and
asyncapi-bot-eve
as code owners
|
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for studio-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Nice PR @Shurtu-gal 🚀
Small things to fix in addition to conflict
| @@ -0,0 +1,57 @@ | |||
| import { useState } from 'react'; | |||
| import toast from 'react-hot-toast'; | |||
| import { create } from '@ebay/nice-modal-react'; | |||
There was a problem hiding this comment.
I see that we've used this library without an ADR, It's fine.
Could we just add an ADR for it, to understand the reasoning behind it.
There was a problem hiding this comment.
Sure, let me check in which commit it was introduced initially.
|
|
/rtm |
|
@asyncapi/bounty_team |
Description
Important
I had tried implementing this through
edge functionsbut turns out that support for npm modules is still sketchy out there leading to the following failure https://app.netlify.com/sites/share-studio/deploys/66e7f0045f2439ebfeadeae6#L150More details: https://ntl.fyi/edge-functions-npm
Related issue(s)
Resolves #127
Resolves #1030