-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long AsyncAPI document URL doesn't work #1030
Comments
If the maintainers think of this as an issue, I would like to work on it. |
@helios2003 this was a known issue before implementing the share feature. The share feature doesn't work for long files. Is there a way to resolve this issue since it's a limitation by the "share" medium itself (i.e. URL)? |
Hi @KhudaDad414, from my knowledge whenever a document is shared the URL is uniquely identified through domain + some-id (of some fixed length) like in Google Docs. Is there any specific reason why the share feature was implemented as such? |
The reason is that we are not storing anything on the server (like the services that you mentioned) so there is no way for us to read the document without passing the entire document in the URL. |
One way that I think can help us solve this issue is compressing the file before converting it to BASE64 and when parsing, doing this but in reverse (convert from BASE64 and decompress) worth looking into. |
Even if we do that, a compression algorithm can only reduce the size by a certain percentage, and for huge documents, it might happen that the URL of the compressed document also exceeds the length limit specified. Also compressing and decompressing also will take some time (though they are rather quick). So won't this hurt user experience? |
@helios2003 I don't think it's that resource-intensive. besides EVERYTHING on the web is compressed with |
Known issue as @KhudaDad414 mentioned. There was a proposal (just an idea of a project) I made time ago but for some reason is closed #127 @KhudaDad414 would you mind reopening it? |
@KhudaDad414 I guess migrating to NextJS will help us find a workaround on the server side. |
In the original issue where @smoya had mentioned a URL Shortener service. Should that not work just fine for this case? However, imho a quick hashing function might be better than a UUID. |
@KhudaDad414 @Amzani That means you are gonna lose the state on each deploy.
@helios2003 The URL shortener mention was just a nice to have. Just by using a URL shortener service doesn't solve anything since the URL shortener service will end up making a redirection to the full URL, meaning the same issue with long URLs will persist. |
BTW, wrote a couple of lines with a new possible implementation for this in #127 (comment) |
Please from now on write new comments regarding implementation details or questions in #127 (comment) |
Bounty Issue's service commentText labels: @asyncapi/bounty_team The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue. |
Assigning to myself. |
Bounty Issue's Timeline
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.Keep in mind the responsibility for violations of the Timeline. |
@Shurtu-gal is an AsyncAPI Maintainer specified in https://raw.githubusercontent.com/asyncapi/community/master/MAINTAINERS.yaml, so they fall under the first category in the prioritization list. |
@aeworxet This bounty issue can be considered as completed. Details are as follows: Video Demoout.mp4Things done
|
Bounty Issue Is Completed 🎉@Shurtu-gal, please go to the AsyncAPI page on Open Collective and submit an invoice for |
Describe the bug
When we have a long AsyncAPI doc and if we try to share it via the copied URL it gives HTTP 414 Error code which translates to URI being too long.
How to Reproduce
async-api-studio.mp4
Expected behavior
The document should be rendered as it is.
The text was updated successfully, but these errors were encountered: