Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: support for messageId #461

Closed
wants to merge 2 commits into from
Closed

add: support for messageId #461

wants to merge 2 commits into from

Conversation

WaleedAshraf
Copy link
Contributor

fixes #458

@WaleedAshraf WaleedAshraf requested a review from derberg November 11, 2020 14:09
@WaleedAshraf WaleedAshraf requested a review from fmvilas November 16, 2020 13:58
fmvilas
fmvilas reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a minor typo fix. Looking great so far for me. Thanks, @WaleedAshraf!

versions/2.0.0/asyncapi.md Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@WaleedAshraf
Copy link
Contributor Author

related PR: asyncapi/spec-json-schemas#24

@WaleedAshraf WaleedAshraf mentioned this pull request Dec 7, 2020
Closed
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jan 17, 2021
@derberg derberg removed the stale label Jan 18, 2021
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Mar 20, 2021
@derberg
Copy link
Member

derberg commented Mar 22, 2021

@WaleedAshraf please adjust the PR, schema is not here in this repo anymore, and spec changed location internally

@WaleedAshraf
Copy link
Contributor Author

@derberg I'll close this for now. Once we know when it can be merge, I'll make new PRs in the respective repo. 👍

@derberg derberg deleted the issue-458 branch February 8, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for messageId
3 participants
@WaleedAshraf @derberg @fmvilas