-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add messageId property to message definition #24
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it should be added here yet. The messageId field is not part of the 2.0.0 spec. It will probably be landing on 2.1.0 or 3.0.0. We should close this PR.
As @derberg said earlier, there is no clear versioning / semver for Schema itself. We have been fixing stuff in 2.0.0, without version bump. |
We have been merging fixes to the schema, which is understandable. This introduces a new feature and that's totally different. |
Ok. Is there some roadmap/plan for 2.1.0? Are there any other new features on hold? |
There are no plans yet. In the upcoming weeks, we'll be announcing a few things that should allow us to move faster :) Regarding things on hold: asyncapi/spec@2.0.0...master. There's at least the Mercure binding waiting. |
And also we have this issue from @lbroudoux to improve message examples. |
Ok. I'll be waiting for announcements ;) Tagging to agenda: asyncapi/spec#462 |
We do have a roadmap (and you're part of the organization on Zehub) but it's impossible for us to follow. That's why I decided not to create a new one yet. It would be utter bullshit from our side to plan things for a whole year when things are moving so fast. We'll follow a different approach soon, just give us time to reorganize :) |
@fmvilas I see it. Yup, that is what I was looking for. 👍 |
This pull request has been automatically marked as stale because it has not had recent activity 😴 |
Kudos, SonarCloud Quality Gate passed! |
This pull request has been automatically marked as stale because it has not had recent activity 😴 |
@WaleedAshraf I suggest we close it and when you are ready to work on it you will open it up properly from a fork and point to a release branch. Agreed? |
issue asyncapi/spec#458