Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add messageId property to message definition #24

Closed
wants to merge 1 commit into from

Conversation

WaleedAshraf
Copy link
Contributor

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@WaleedAshraf WaleedAshraf requested a review from derberg November 17, 2020 14:05
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be added here yet. The messageId field is not part of the 2.0.0 spec. It will probably be landing on 2.1.0 or 3.0.0. We should close this PR.

@WaleedAshraf
Copy link
Contributor Author

As @derberg said earlier, there is no clear versioning / semver for Schema itself. We have been fixing stuff in 2.0.0, without version bump.

@fmvilas
Copy link
Member

fmvilas commented Nov 18, 2020

We have been merging fixes to the schema, which is understandable. This introduces a new feature and that's totally different.

@WaleedAshraf
Copy link
Contributor Author

Ok. Is there some roadmap/plan for 2.1.0? Are there any other new features on hold?

@fmvilas
Copy link
Member

fmvilas commented Nov 18, 2020

There are no plans yet. In the upcoming weeks, we'll be announcing a few things that should allow us to move faster :)

Regarding things on hold: asyncapi/spec@2.0.0...master. There's at least the Mercure binding waiting.

@derberg
Copy link
Member

derberg commented Nov 18, 2020

And also we have this issue from @lbroudoux to improve message examples.
We had those grouped under https://github.com/asyncapi/asyncapi/issues/353 (you need to have zenhub installed to see related linked issues to this epic) but that will need review as it is few months old

@WaleedAshraf
Copy link
Contributor Author

WaleedAshraf commented Nov 18, 2020

Ok. I'll be waiting for announcements ;)
You guys would be working on a lot of things but having a roadmap would help both sides. (users and core contributors)
I'll try to hop-on on the next weekly meeting to have some more details about this.

Tagging to agenda: asyncapi/spec#462

@fmvilas
Copy link
Member

fmvilas commented Nov 19, 2020

We do have a roadmap (and you're part of the organization on Zehub) but it's impossible for us to follow. That's why I decided not to create a new one yet. It would be utter bullshit from our side to plan things for a whole year when things are moving so fast. We'll follow a different approach soon, just give us time to reorganize :)

@WaleedAshraf
Copy link
Contributor Author

@fmvilas I see it. Yup, that is what I was looking for. 👍
I understand (and see) there's a bunch of stuff ongoing. Hopefully from next year, things will be in better shape.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jan 19, 2021
@github-actions github-actions bot closed this Mar 21, 2021
@derberg derberg reopened this Mar 22, 2021
@derberg derberg removed the stale label Mar 22, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label May 22, 2021
@derberg
Copy link
Member

derberg commented May 24, 2021

@WaleedAshraf I suggest we close it and when you are ready to work on it you will open it up properly from a fork and point to a release branch. Agreed?

@smoya smoya deleted the issue-458 branch November 26, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants