ci: added code linting #473

Gmin2 · 2023-12-17T08:27:36Z

Description
this pr introduces linting in the repo
Related issue(s)
fix #467

github-actions

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

smoya · 2023-12-17T08:35:45Z

@Min2who please update the title of the PR according to the semantic-release prefixes (as shown in the checks). In this case, the prefix is ci.

AnimeshKumar923 · 2023-12-17T10:32:06Z

@smoya sorry to bother but the workflow requires your approval

AnimeshKumar923 · 2023-12-17T10:33:54Z

package.json

@@ -11,7 +11,8 @@
    "prepublishOnly": "npm run build",
    "bundle": "cd tools/bundler && npm i && npm run bundle",
    "startNewVersion": "newVersion=$npm_config_new_version node scripts/add-new-version.js",
-    "lint": "echo 'No linter integrated yet'",
+    "lint": "eslint --max-warnings 0 --config .eslintrs .",


Suggested change

"lint": "eslint --max-warnings 0 --config .eslintrs .",

"lint": "eslint --max-warnings 0 --config .eslintrc .",

I think this is why the workflow failed earlier, @Min2who please fix this. The file name is not matched correctly

Resolved with da9d4ce

AnimeshKumar923 · 2023-12-17T10:39:24Z

package.json

@@ -11,7 +11,8 @@
    "prepublishOnly": "npm run build",
    "bundle": "cd tools/bundler && npm i && npm run bundle",
    "startNewVersion": "newVersion=$npm_config_new_version node scripts/add-new-version.js",
-    "lint": "echo 'No linter integrated yet'",
+    "lint": "eslint --max-warnings 0 --config .eslintrc .",
+    "lint:fix": "eslint --max-warnings 0 --config . --fix",


Suggested change

"lint:fix": "eslint --max-warnings 0 --config . --fix",

"lint:fix": "eslint --max-warnings 0 --config .eslintrc . --fix",

@Min2who This should be as given here

smoya · 2023-12-18T11:24:02Z

@Min2who Can this be turned in to a final PR? Looks ok to me.

Gmin2 · 2023-12-18T15:32:18Z

@Min2who Can this be turned in to a final PR? Looks ok to me.

@smoya done

smoya · 2023-12-19T01:18:24Z

@Min2who PR Testing workflow is failing https://github.com/asyncapi/spec-json-schemas/actions/runs/7250263375/job/19767638609?pr=473#step:11:31

smoya · 2023-12-19T10:27:41Z

The tests are now failing because of linting issues 👍
Perhaps it makes sense to run a npm run lint:fix and commit the result here.

Gmin2 · 2023-12-19T13:52:40Z

@smoya if i dont add comment disabling the eslint error it fails npm run lint and if i do as in this case it is failing sonarcloud code analysis what should i do

AnimeshKumar923 · 2023-12-26T22:45:42Z

Hey @smoya @Min2who 👋
I tried doing the steps you provided in the issue and I'm also getting the same issue as the one which SonarCloud is giving.

After running npm run lint, the following output is being given 👇

> @asyncapi/[email protected] lint
> eslint --max-warnings 0 --config .eslintrc.yml .


Oops! Something went wrong! :(

ESLint: 8.56.0

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Object'
    |     property 'security' -> object with constructor 'Object'
    |     property 'configs' -> object with constructor 'Object'
    |     property 'recommended' -> object with constructor 'Object'
    --- property 'plugins' closes the circle
Referenced from: /home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/.eslintrc.yml
    at JSON.stringify (<anonymous>)
    at /home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2156:45
    at Array.map (<anonymous>)
    at ConfigValidator.formatErrors (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2147:23)
    at ConfigValidator.validateConfigSchema (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2177:84)
    at ConfigArrayFactory._normalizeConfigData (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:19)
    at ConfigArrayFactory._loadExtendedPluginConfig (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3239:25)
    at ConfigArrayFactory._loadExtends (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3154:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)

@smoya currently I'm not having that much knowledge to debug this 😅 . You'd know better as you've knowledge of the codebase and how things are working internally, so would require you help here...

.eslintrc

+      - "test/**"
+      - "*.spec.js"
+      - "*.test.js"


package.json

@@ -11,7 +11,8 @@
    "prepublishOnly": "npm run build",
    "bundle": "cd tools/bundler && npm i && npm run bundle",
    "startNewVersion": "newVersion=$npm_config_new_version node scripts/add-new-version.js",
-    "lint": "echo 'No linter integrated yet'",
+    "lint": "eslint --max-warnings 0 --config .eslintrc .",
+    "lint:fix": "eslint --max-warnings 0 --config . --fix",


package.json

@@ -11,7 +11,8 @@
    "prepublishOnly": "npm run build",
    "bundle": "cd tools/bundler && npm i && npm run bundle",
    "startNewVersion": "newVersion=$npm_config_new_version node scripts/add-new-version.js",
-    "lint": "echo 'No linter integrated yet'",
+    "lint": "eslint --max-warnings 0 --config .eslintrc .",
+    "lint:fix": "eslint --max-warnings 0 --config . --fix",


package.json

@@ -11,7 +11,8 @@
    "prepublishOnly": "npm run build",
    "bundle": "cd tools/bundler && npm i && npm run bundle",
    "startNewVersion": "newVersion=$npm_config_new_version node scripts/add-new-version.js",
-    "lint": "echo 'No linter integrated yet'",
+    "lint": "eslint --max-warnings 0 --config .eslintrs .",


AnimeshKumar923 · 2023-12-26T22:47:03Z

.eslintrc.yml

@@ -0,0 +1,112 @@
+parser: "@typescript-eslint/parser"


@Min2who is this needed here? I guess TypeScript and related technologies are not to be used in this PR.

i found the typescript parser to be best among the babel and ecma parser

I agree this feels unexpected. We are not using Typescript (yet) in this project, so I expect all JS files to fulfill with standard vanilla JS.

Unless there is a strong reason to use this, please remove this line.

scripts/add-new-version.js

smoya · 2024-01-09T15:23:40Z

scripts/validate-schemas.js

@@ -7,82 +7,77 @@ const ajvDraft04 = new AjvDraft04();
 const Ajv = require('ajv');
 const ajv = new Ajv();

-function validation (excludedFiles){
-
+/* eslint-disable sonarjs/cognitive-complexity */


@AnimeshKumar923 As you recently created this script, would you be happy improving it by reducing the cognitive complexity Sonarcloud complains at this moment? I guess it is a matter of simplifying the script.

If so, let's create a new issue for it.

tools/bundler/index.js

AnimeshKumar923 · 2024-01-10T02:28:25Z

Hey @smoya @Min2who 👋 I tried doing the steps you provided in the issue and I'm also getting the same issue as the one which SonarCloud is giving.
After running npm run lint, the following output is being given 👇

> @asyncapi/[email protected] lint
> eslint --max-warnings 0 --config .eslintrc.yml .


Oops! Something went wrong! :(

ESLint: 8.56.0

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Object'
    |     property 'security' -> object with constructor 'Object'
    |     property 'configs' -> object with constructor 'Object'
    |     property 'recommended' -> object with constructor 'Object'
    --- property 'plugins' closes the circle
Referenced from: /home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/.eslintrc.yml
    at JSON.stringify (<anonymous>)
    at /home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2156:45
    at Array.map (<anonymous>)
    at ConfigValidator.formatErrors (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2147:23)
    at ConfigValidator.validateConfigSchema (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2177:84)
    at ConfigArrayFactory._normalizeConfigData (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:19)
    at ConfigArrayFactory._loadExtendedPluginConfig (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3239:25)
    at ConfigArrayFactory._loadExtends (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3154:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)

@smoya currently I'm not having that much knowledge to debug this 😅 . You'd know better as you've knowledge of the codebase and how things are working internally, so would require you help here...

I can't reproduce this error. Ran this locally and worked fine.

It seems it's no longer giving the error. But a different error this time which is mentioned here in the 2nd screenshot: #473 (comment)

Gmin2 · 2024-01-10T05:38:30Z

Hey @smoya @Min2who 👋 I tried doing the steps you provided in the issue and I'm also getting the same issue as the one which SonarCloud is giving.
After running npm run lint, the following output is being given 👇

> @asyncapi/[email protected] lint
> eslint --max-warnings 0 --config .eslintrc.yml .


Oops! Something went wrong! :(

ESLint: 8.56.0

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Object'
    |     property 'security' -> object with constructor 'Object'
    |     property 'configs' -> object with constructor 'Object'
    |     property 'recommended' -> object with constructor 'Object'
    --- property 'plugins' closes the circle
Referenced from: /home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/.eslintrc.yml
    at JSON.stringify (<anonymous>)
    at /home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2156:45
    at Array.map (<anonymous>)
    at ConfigValidator.formatErrors (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2147:23)
    at ConfigValidator.validateConfigSchema (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2177:84)
    at ConfigArrayFactory._normalizeConfigData (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:19)
    at ConfigArrayFactory._loadExtendedPluginConfig (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3239:25)
    at ConfigArrayFactory._loadExtends (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3154:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)

@smoya currently I'm not having that much knowledge to debug this 😅 . You'd know better as you've knowledge of the codebase and how things are working internally, so would require you help here...

I can't reproduce this error. Ran this locally and worked fine.

It seems it's no longer giving the error. But a different error this time which is mentioned here in the 2nd screenshot: #473 (comment)

If we use espree parser (the default eslint parser) then this error occur.But if we use babel-eslint parser this error does not occur

smoya · 2024-01-10T09:08:13Z

Hey @smoya @Min2who 👋 I tried doing the steps you provided in the issue and I'm also getting the same issue as the one which SonarCloud is giving.
After running npm run lint, the following output is being given 👇

> @asyncapi/[email protected] lint
> eslint --max-warnings 0 --config .eslintrc.yml .


Oops! Something went wrong! :(

ESLint: 8.56.0

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Object'
    |     property 'security' -> object with constructor 'Object'
    |     property 'configs' -> object with constructor 'Object'
    |     property 'recommended' -> object with constructor 'Object'
    --- property 'plugins' closes the circle
Referenced from: /home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/.eslintrc.yml
    at JSON.stringify (<anonymous>)
    at /home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2156:45
    at Array.map (<anonymous>)
    at ConfigValidator.formatErrors (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2147:23)
    at ConfigValidator.validateConfigSchema (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2177:84)
    at ConfigArrayFactory._normalizeConfigData (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:19)
    at ConfigArrayFactory._loadExtendedPluginConfig (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3239:25)
    at ConfigArrayFactory._loadExtends (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3154:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/animeshkumar923/Desktop/open-source/asyncapi-spec-json-schemas/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)

@smoya currently I'm not having that much knowledge to debug this 😅 . You'd know better as you've knowledge of the codebase and how things are working internally, so would require you help here...

I can't reproduce this error. Ran this locally and worked fine.

It seems it's no longer giving the error. But a different error this time which is mentioned here in the 2nd screenshot: #473 (comment)

If we use espree parser (the default eslint parser) then this error occur.But if we use babel-eslint parser this error does not occur

But that error is expected. We should fix the code and not hiding it by using another eslint parser.

AnimeshKumar923 · 2024-01-11T00:23:31Z

But that error is expected. We should fix the code and not hiding it by using another eslint parser.

I think we should create a new issue and proceed to resolve it and then after resolution the linting would pass.

Thoughts?

smoya · 2024-01-11T15:19:38Z

.eslintrc.yml

+  - plugin:sonarjs/recommended
+
+parserOptions:
+  requireConfigFile: false


Needed to make it work with async

Suggested change

requireConfigFile: false

requireConfigFile: false

ecmaVersion: 2018

smoya · 2024-01-11T15:20:46Z

scripts/add-new-version.js

@@ -42,29 +42,29 @@ function addNewSchemaVersion(newVersion, newVersionDir, latestVersion) {
  const obj = require(objFile);

  // Adapt all the MUST supported schema formats
-  let mustSupportedSchemaFormats = [] = obj?.else?.properties?.schemaFormat?.anyOf[1]?.enum;
+  let mustSupportedSchemaFormats = obj?.else?.properties?.schemaFormat?.anyOf[1]?.enum || [];


Ugly, but i can't come with another solution compatible with this version of ES.

You will need to apply the same approach for the rest.

Suggested change

let mustSupportedSchemaFormats = obj?.else?.properties?.schemaFormat?.anyOf[1]?.enum || [];

let mustSupportedSchemaFormats = obj && obj.else && obj.else.properties && obj.else.properties.schemaFormat && obj.else.properties.schemaFormat.anyOf && obj.else.properties.schemaFormat.anyOf[1] && obj.else.properties.schemaFormat.anyOf[1].enum ? obj.else.properties.schemaFormat.anyOf[1].enum : [];

smoya · 2024-01-11T15:21:41Z

But that error is expected. We should fix the code and not hiding it by using another eslint parser.

I think we should create a new issue and proceed to resolve it and then after resolution the linting would pass.

Thoughts?

I don't mind if done here or outside.

I dropped a suggestion on how to fix it (ugly but 🤷 ) https://github.com/asyncapi/spec-json-schemas/pull/473/files#r1449018980

AnimeshKumar923 · 2024-01-11T18:20:06Z

But that error is expected. We should fix the code and not hiding it by using another eslint parser.

I think we should create a new issue and proceed to resolve it and then after resolution the linting would pass.
Thoughts?

I don't mind if done here or outside.

I dropped a suggestion on how to fix it (ugly but 🤷 ) https://github.com/asyncapi/spec-json-schemas/pull/473/files#r1449018980

If it's not that significant of a change (assuming it won't stretch out too far if we implement it), I think it would be okay do it in this PR itself. 👍

Gmin2 · 2024-01-12T08:41:26Z

But that error is expected. We should fix the code and not hiding it by using another eslint parser.

I think we should create a new issue and proceed to resolve it and then after resolution the linting would pass.
Thoughts?

I don't mind if done here or outside.
I dropped a suggestion on how to fix it (ugly but 🤷 ) https://github.com/asyncapi/spec-json-schemas/pull/473/files#r1449018980

If it's not that significant of a change (assuming it won't stretch out too far if we implement it), I think it would be okay do it in this PR itself. 👍

@AnimeshKumar923 doing this change in this pr only after completing #482

AnimeshKumar923 · 2024-01-31T13:49:47Z

@Min2who I think you can start working on this one now as #482 got resolved.

Gmin2 · 2024-02-01T11:56:52Z

@Min2who I think you can start working on this one now as #482 got resolved.

done @AnimeshKumar923 👍

sonarqubecloud · 2024-02-01T12:27:21Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

smoya

LGTM! 🚀🌔

smoya · 2024-02-02T14:27:10Z

pinging random mantainers to review besides me @dalelane @char0n

dalelane

looks good to me

The impact of the "no-unsafe-optional-chaining" rule was an interesting one to me, I hadn't come across that before, because at first glance I was going to say this makes the code less readable - but having read the docs for the lint rule, I see now why you've done this.

smoya · 2024-02-02T17:54:38Z

/rtm

asyncapi-bot · 2024-02-04T10:33:31Z

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

added code linting

34f087b

Gmin2 requested review from fmvilas, derberg, dalelane, smoya, char0n and asyncapi-bot-eve as code owners December 17, 2023 08:27

github-actions bot reviewed Dec 17, 2023

View reviewed changes

Gmin2 marked this pull request as draft December 17, 2023 08:28

Gmin2 changed the title ~~added code linting~~ ci: added code linting Dec 17, 2023

added eslintignore

c3e7dbd

AnimeshKumar923 mentioned this pull request Dec 17, 2023

Add code linting (eslint) as part of CI script #467

Closed

4 tasks

AnimeshKumar923 reviewed Dec 17, 2023

View reviewed changes

fix a typo

da9d4ce

AnimeshKumar923 reviewed Dec 17, 2023

View reviewed changes

a small change

6fbc667

Gmin2 marked this pull request as ready for review December 18, 2023 15:31

resolves the failing test

57c78e7

Gmin2 added 2 commits December 19, 2023 19:10

remove all lintng errors

0f2bc17

lol

2fe5ccf

Gmin2 requested a review from AnimeshKumar923 December 26, 2023 08:12

AnimeshKumar923 reviewed Dec 26, 2023

View reviewed changes

smoya reviewed Jan 9, 2024

View reviewed changes

scripts/add-new-version.js Outdated Show resolved Hide resolved

smoya reviewed Jan 9, 2024

View reviewed changes

tools/bundler/index.js Outdated Show resolved Hide resolved

added the reviewed changes

12bcdeb

Gmin2 requested a review from smoya January 9, 2024 15:53

smoya reviewed Jan 11, 2024

View reviewed changes

Gmin2 mentioned this pull request Jan 29, 2024

fix: reduced the complexity of validate-schema.js #483

Merged

spdated with default parser and remove optional chaining

680a98c

Gmin2 and others added 3 commits February 1, 2024 17:39

remove some conflict and remove nested ternary operator

2a57d2b

Merge branch 'master' into lint

dc6b823

cleanup

ce28b57

smoya approved these changes Feb 2, 2024

View reviewed changes

dalelane approved these changes Feb 2, 2024

View reviewed changes

asyncapi-bot added the ready-to-merge label Feb 2, 2024

asyncapi-bot merged commit 4021e8e into asyncapi:master Feb 2, 2024
10 checks passed

asyncapi-bot added the released label Feb 4, 2024

	"lint": "eslint --max-warnings 0 --config .eslintrs .",
	"lint": "eslint --max-warnings 0 --config .eslintrc .",

	"lint:fix": "eslint --max-warnings 0 --config . --fix",
	"lint:fix": "eslint --max-warnings 0 --config .eslintrc . --fix",

	requireConfigFile: false
	requireConfigFile: false
	ecmaVersion: 2018

	let mustSupportedSchemaFormats = obj?.else?.properties?.schemaFormat?.anyOf[1]?.enum \|\| [];
	let mustSupportedSchemaFormats = obj && obj.else && obj.else.properties && obj.else.properties.schemaFormat && obj.else.properties.schemaFormat.anyOf && obj.else.properties.schemaFormat.anyOf[1] && obj.else.properties.schemaFormat.anyOf[1].enum ? obj.else.properties.schemaFormat.anyOf[1].enum : [];

ci: added code linting #473

ci: added code linting #473

Conversation

Gmin2 commented Dec 17, 2023 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

smoya commented Dec 17, 2023

AnimeshKumar923 commented Dec 17, 2023

AnimeshKumar923 Dec 17, 2023 • edited Loading

Choose a reason for hiding this comment

AnimeshKumar923 Dec 17, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

AnimeshKumar923 Dec 17, 2023 • edited Loading

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

smoya commented Dec 18, 2023

Gmin2 commented Dec 18, 2023

smoya commented Dec 19, 2023

smoya commented Dec 19, 2023

Gmin2 commented Dec 19, 2023

AnimeshKumar923 commented Dec 26, 2023

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

AnimeshKumar923 Dec 26, 2023

Choose a reason for hiding this comment

Gmin2 Dec 27, 2023

Choose a reason for hiding this comment

smoya Jan 8, 2024 • edited Loading

Choose a reason for hiding this comment

smoya Jan 9, 2024

Choose a reason for hiding this comment

AnimeshKumar923 commented Jan 10, 2024

Gmin2 commented Jan 10, 2024

smoya commented Jan 10, 2024

AnimeshKumar923 commented Jan 11, 2024

smoya Jan 11, 2024

Choose a reason for hiding this comment

smoya Jan 11, 2024

Choose a reason for hiding this comment

smoya commented Jan 11, 2024

AnimeshKumar923 commented Jan 11, 2024

Gmin2 commented Jan 12, 2024

AnimeshKumar923 commented Jan 31, 2024 • edited Loading

Gmin2 commented Feb 1, 2024

sonarqubecloud bot commented Feb 1, 2024

Quality Gate passed

smoya left a comment

Choose a reason for hiding this comment

smoya commented Feb 2, 2024

dalelane left a comment

Choose a reason for hiding this comment

smoya commented Feb 2, 2024

asyncapi-bot commented Feb 4, 2024

Gmin2 commented Dec 17, 2023 •

edited

Loading

AnimeshKumar923 Dec 17, 2023 •

edited

Loading

AnimeshKumar923 Dec 17, 2023 •

edited

Loading

smoya Jan 8, 2024 •

edited

Loading

AnimeshKumar923 commented Jan 31, 2024 •

edited

Loading