-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code linting (eslint) as part of CI script #467
Comments
I would like to work on this issue. |
Of course! Feel free to create a PR at anytime 🚀 |
@AnimeshKumar923 can i go ahead with this |
@smoya I would like to give @Min2who this issue. @Min2who Please go ahead with this issue 👍 |
thnx @AnimeshKumar923 |
Welcome! Let me know if you encounter any difficulties... |
@smoya @AnimeshKumar923 how do i ensure this |
About this, @smoya If I rememeber correctly, Lukasz talked about modifying the workflows in Because if we modify in this repo, it will later be overwritten. So to make it permanent, we should follow the above said approach. Thoughts? 👀 context: #452 (review) |
The workflow is already calling the lint script https://github.com/asyncapi/.github/blob/master/.github%2Fworkflows%2Fif-nodejs-pr-testing.yml#L74-L75 |
Okay, then as I can see in #473, it will be executed after merging. |
thnx @smoya @AnimeshKumar923 for the info |
🎉 This issue has been resolved in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Reason/Context
The number of JS files is growing lately, and I feel it's about time to let all these code pass through a code linter in order to ensure consistency and follow standards, also to find and fix potential bugs.
Description
.eslintrc
and.eslintrcignore
files based on, for example, parser-js. Be aware this project doesn't use TypeScript, so modification of those files might be needed.npm lint
andnpm lint:fix
as, for example, parser-js has.The text was updated successfully, but these errors were encountered: