Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release for version 2.4.0 of the spec #185

Merged
merged 12 commits into from
Apr 27, 2022
Merged

Conversation

smoya
Copy link
Member

@smoya smoya commented Mar 21, 2022

This PR is created upfront to reflect on a daily basis what things are included in the release.

Also, the reason to create this PR a long time before the release is to enable automation (bot keeps upstream branches always up to date with master, see this action) that we have in place to regularly update the release branch with whatever is changed in the master branch. So nobody has to do it manually.

@smoya
Copy link
Member Author

smoya commented Mar 21, 2022

/dnm

@smoya
Copy link
Member Author

smoya commented Apr 13, 2022

/autoupdate

@smoya
Copy link
Member Author

smoya commented Apr 13, 2022

Even though #184 is going to be merged very soon, and all the opened PR's for 2.4 are using the one-file json schema version, we would need to adapt all the changes into the new file structure.
As there are no so much changes, I volunteer to do the required changes for adapting those changes to the new structure once all PR's for 2.4 are merged into this release branch (2022-04-release).

cc @jonaslagoni @fmvilas

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya
Copy link
Member Author

smoya commented Apr 27, 2022

@dalelane @fmvilas @derberg need a +1 on this + remove do-not-merge label so we can merge and release it 🙏

@@ -1,6 +1,6 @@
{
"name": "@asyncapi/specs",
"version": "2.13.2",
"version": "2.14.0-2022-04-release.3",
Copy link
Member

@magicmatatjahu magicmatatjahu Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be probably changed to the 2.13.2

Suggested change
"version": "2.14.0-2022-04-release.3",
"version": "2.13.2",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, RC should stay, semantic-release will figure it out, notice 2.13 and bump to 2.14 🍻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ❤️

@smoya
Copy link
Member Author

smoya commented Apr 27, 2022

Only @dalelane approval is left and Ok to go!

Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry for the delay!)

@derberg
Copy link
Member

derberg commented Apr 27, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 3d5d18e into master Apr 27, 2022
@asyncapi-bot asyncapi-bot deleted the 2022-04-release branch April 27, 2022 13:59
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants