feat: security support added to operation and operationTrait #189
Conversation
LokeshRishi
requested review from
fmvilas,
derberg,
dalelane and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for the PR @LokeshRishi! would you mind changing the title of this PR adding a prefix to be compliant with Conventional Commits? |
| @@ -616,6 +616,12 @@ | |||
| "operationId": { | |||
| "type": "string" | |||
| }, | |||
| "security": { | |||
There was a problem hiding this comment.
Would it make sense to extract this into a new definition called SecurityRequirements or similar? Then you will just need to use it by "$ref": "#/definitions/SecurityRequirements"
There was a problem hiding this comment.
Would it make sense to extract this into a new definition called
SecurityRequirementsor similar? Then you will just need to use it by"$ref": "#/definitions/SecurityRequirements"
Hi @smoya - Its an array of SecurityRequirements. Not sure if just indicating an array of a complex definition warrants a new definition. If so, such a pattern would need to apply consistently to all similar constructs that refer to an array (tags for example). Not sure it carries much benefits. At least for me - not creating a new definition but just knowing its an array of an existing definition is easier. Up to you folks :)
There was a problem hiding this comment.
Fair enough 👍 I agree we would need to be consistent and lot of changes will need to be applied.
LokeshRishi
changed the title
There was a problem hiding this comment.
@fmvilas only your approval is missing
I put asyncapi/spec#584 on Stage 2,
once we merge this and parser PR, then we can set Stage 3 and merge
|
/rtm |
|
Hello, @smoya! 👋🏼 |
|
/au |
|
🎉 This PR is included in version 2.14.0-2022-04-release.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 passing (789ms)
----------|---------|----------|---------|---------|-------------------
Description
Updates to include 'security' at operation and operationTrait level.
Related issue(s)
asyncapi/spec#584