feat: display protocol bindings on server, channel, operation, message #176
Conversation
M3lkior
force-pushed
the
feat/display-bindings
branch
2 times, most recently
from
1fa4479 to
cc791fd
Compare
|
@M3lkior what about server bindings?
sorry but I didn't get that |
partials/protocols.html
Outdated
| {% endmacro %} | ||
|
|
||
|
|
||
| {% macro bindings(eltName, elt, odd=false) %} |
There was a problem hiding this comment.
like element? if they then better use prop that is common in other macros in this template
There was a problem hiding this comment.
yes this is for element because this macro can take a Message element, or a Channel or an Operation ... etc
There was a problem hiding this comment.
Awesome! For me everything is good, except only what @derberg wrote about elt could be improved to make it clearer.
it was a bug in the code ;) all is good now (i actualized my screenshot) |
M3lkior
force-pushed
the
feat/display-bindings
branch
from
72b3e10 to
f4a6250
Compare
partials/protocols.html
Outdated
|
|
||
| {% if prop.hasBindings() %} | ||
| {% for protocol in prop.bindingProtocols() %} | ||
| <div class="{% if open %}is-open{% endif %} mb-4"> |
There was a problem hiding this comment.
usage of mt-4 make it look much more aligned, have a look
There was a problem hiding this comment.
Done ; i do uniformization to align all elements (even in the collapsed blocks)
I think that we need to develop a macro for those blocks (in order to keep the same style over all rendering blocks)
|
I just left one comment on visuals, but in general, it looks great. I think we need to get https://github.com/M3lkior/html-template/tree/feat/display-bindings merged first. and what about rendering bindings for a server? |
|
Kudos, SonarCloud Quality Gate passed!
|
Oups .. done this is the related rendering : |
derberg
changed the title
|
🎉 This PR is included in version 0.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Here is the result with the dummy file on asyncapi/generator#556
Channel and operation bindings :
By the way, it seems that settings bindings on a channel is not handle by the parser (see the dummy file content and the related generation)
For message bindings :
Resolves #25