Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add extra bindings to dummy.yml #556

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

M3lkior
Copy link
Contributor

@M3lkior M3lkior commented Apr 2, 2021

This specification evolution is useful to illustrate asyncapi/html-template#25

@M3lkior M3lkior changed the title Docs/add bindings docs/add bindings Apr 2, 2021
@M3lkior M3lkior changed the title docs/add bindings docs: add extra bindings Apr 2, 2021
@derberg
Copy link
Member

derberg commented Apr 12, 2021

@M3lkior is it still draft? shouldn't you resolve conflicts and make it ready for review?

@M3lkior M3lkior marked this pull request as ready for review April 12, 2021 09:34
@M3lkior M3lkior force-pushed the docs/add-bindings branch from 56a86e8 to b3ee088 Compare April 12, 2021 09:37
@M3lkior
Copy link
Contributor Author

M3lkior commented Apr 12, 2021

@M3lkior is it still draft? shouldn't you resolve conflicts and make it ready for review?

done :)

@derberg
Copy link
Member

derberg commented Apr 12, 2021

@M3lkior I think some autoformatted from your IDE did many changes to lines in snapshot tests and now they all fail

@derberg derberg changed the title docs: add extra bindings docs: add extra bindings to dummy.yml Apr 12, 2021
@M3lkior M3lkior force-pushed the docs/add-bindings branch from 0a81704 to fc55c52 Compare April 12, 2021 10:38
@M3lkior M3lkior force-pushed the docs/add-bindings branch from fc55c52 to d2640e4 Compare April 12, 2021 10:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg merged commit b902116 into asyncapi:master Apr 12, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.6.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants