Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fs.stats instead of deprecated fs.exists which uses invalid callback args. #838

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

nodify-at
Copy link
Contributor

@nodify-at nodify-at commented Sep 21, 2022

Description
Replaces fs.exists with fs.stats, wrapped utils.exists to keep the code base stable.

Related issue(s)

Resolves #836

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu changed the title fix: use fs.stats instead of deprecated fs.exists which uses invalid … fix: use fs.stats instead of deprecated fs.exists which uses invalid callback args. Sep 21, 2022
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit bdd9ee6 into asyncapi:master Sep 21, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace fs.exists with fs.stats
3 participants