Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fs.exists with fs.stats #836

Closed
nodify-at opened this issue Sep 20, 2022 · 4 comments · Fixed by #838
Closed

Replace fs.exists with fs.stats #836

nodify-at opened this issue Sep 20, 2022 · 4 comments · Fixed by #838
Labels
enhancement New feature or request released

Comments

@nodify-at
Copy link
Contributor

nodify-at commented Sep 20, 2022 •
edited
Loading

Reason/Context

fs.exists function is deprecated (see: https://nodejs.org/docs/latest-v14.x/api/fs.html#fs_fs_exists_path_callback) and it causes to unstable behaviour if used with promisify with async hooks. (see: open-telemetry/opentelemetry-js-contrib#1185)

Description

We can use fs.stat() as it is suggested in node.js official documentation.

This change won't break any functionality, we can release a patch version. I can prepare a PR if it is OK for you :)
@nodify-at nodify-at added the enhancement New feature or request label Sep 20, 2022
@github-actions
Copy link
Contributor

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@magicmatatjahu
Copy link
Member

@nodify-at Hi!

This change won't break any functionality, we can release a patch version. I can prepare a PR if it is OK for you :)

Sure, go ahead :)

@nodify-at nodify-at mentioned this issue Sep 21, 2022
Merged
@nodify-at
Copy link
Contributor Author

@magicmatatjahu I create a PR :) Thanks. (#838)

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.9.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
3 participants
@magicmatatjahu @nodify-at @asyncapi-bot