Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ambassador program (FAQ) #361

Merged
merged 52 commits into from
Aug 31, 2022
Merged

Conversation

Barbanio
Copy link
Contributor

@Barbanio Barbanio commented May 12, 2022

Description

  • This document covers the organizational and practical aspects of the AsyncAPI Ambassador Program. (FAQ)

  • Once this PR is merged, ambassadors.json will be provided with the list of proposed initial ambassadors that fulfill the requirements.

Related issue(s)
See also #635.

@Barbanio Barbanio changed the title Enhancement: AsyncAPI Ambassador Program (FAQ) AMBASSADOR_PROGRAM_(FAQ) May 12, 2022
@Barbanio Barbanio changed the title AMBASSADOR_PROGRAM_(FAQ) chore: Ambassador program (FAQ) May 12, 2022
@Barbanio Barbanio changed the title chore: Ambassador program (FAQ) chore: ambassador program (FAQ) May 12, 2022
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments, looking good so far

AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
Barbanio and others added 4 commits May 24, 2022 21:58
Co-authored-by: Lukasz Gornicki <[email protected]>
Added link code of conduct.
Co-authored-by: Lukasz Gornicki <[email protected]>
Added Lukasz's suggestions.
@Barbanio Barbanio requested a review from derberg May 26, 2022 11:52
@Leamsi9
Copy link

Leamsi9 commented May 29, 2022

The only things that were not totally clear for me from reading this is whether you need to already have made the 4 contributions before becoming an ambassador, or whether a commitment to do so within a year is enough.

Also wasn't very clear whether commenting on the repo in issues like this one counts as contribution? I would suggest yes, as long as the evaluating panel gets a say on whether those engagements are significant enough to count for one of the 4 contributions?

Likewise, when assessing contributions, you specify that talks can be one, and blogs/postings etc another. Not sure if we need to specify this but a question might be, if you give and record a talk in a meetup, and then post the video in a separate forum, does that count as one or two contributions?

@Barbanio
Copy link
Contributor Author

@Leamsi9 Thanks for your feedback!

  1. I always understood that it is applied retroactively, so that person has previously demonstrated commitment to the project. I don't know if I'm wrong, @derberg.

  2. It makes sense that overall participation in the project should be considered another contribution toward the Ambassadors program. We need a tool that can quantify this participation objectively and transparently.

  3. I understand this as a single contribution. The diffusion of the talk is a consequence of this.

@derberg
Copy link
Member

derberg commented May 30, 2022

  • yes, you first demonstrate contribution and then you become an ambassador, not before
  • yes, other contributions like GitHub activity, twitter activity, LinkedIn activity could be counted as contributions, we just do not have a tool yet that can count it. Linux Foundation has one, but they did not give us access yet as they are now in the process of migrating from v1 to v2 and do not onboard new projects until July 2022
  • yeah, if the video is a recording of a talk, it is the same as the talk itself, and video is just a proof.

anyway, your question about video made me thing that we should extend description of blog post contribution. In the end not everyone likes to read, some like videos, some podcasts, we should treat these equally and count as contribution. Example is this video from Dale -> https://www.youtube.com/watch?v=Ni5tCY9r0TY

Added podcasts and videos as possible contributions.
@Leamsi9
Copy link

Leamsi9 commented May 31, 2022

Re: repo contributions, this looks like a good tool, quick to implement:
https://github.com/X-lab2017/open-digger

It's behind the excellent Open Source Insights report https://www.freecodecamp.org/news/open-source-insights-what-we-learned-from-860-million-github-event-logs/

It produces a ranking based on the following weighting:

const ISSUE_COMMENT_WEIGHT = 1; const OPEN_ISSUE_WEIGHT = 2; const OPEN_PULL_WEIGHT = 3; const REVIEW_COMMENT_WEIGHT = 4; const PULL_MERGED_WEIGHT = 2;

@derberg
Copy link
Member

derberg commented Jun 13, 2022

@Leamsi9 I'm basically reluctant to build another custom stuff if I know that in a month or two we can get something similar from Linux Founation 😅

AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
@derberg
Copy link
Member

derberg commented Jun 13, 2022

@alequetzalli I did my review, I still need to work with @Barbanio on the shape of ambassadors.json file and the initial list of ambassadors, but you could already have a look before we pass it to TSC for voting to accept the program, kindly please 🙏🏼

Barbanio and others added 2 commits June 13, 2022 16:55
Added Lukasz's suggestion.

Co-authored-by: Lukasz Gornicki <[email protected]>
Added Lukasz's suggestion.

Co-authored-by: Lukasz Gornicki <[email protected]>
@derberg
Copy link
Member

derberg commented Jun 28, 2022

@Barbanio please adjust values of the packages to match more or less the current state, or just specify that it is approximate value

@alequetzalli pingy pongy

@quetzalliwrites
Copy link
Member

This is soooo amazing, @Barbanio! I think the last feedback from @derberg really helped get this ready to go.

I only saw 3 tiny items that I recommended a fix for, but the rest looks great! 😊

Co-authored-by: Alejandra Quetzalli  <[email protected]>
Barbanio and others added 3 commits August 9, 2022 07:11
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
Co-authored-by: Alejandra Quetzalli  <[email protected]>
@Barbanio
Copy link
Contributor Author

Barbanio commented Aug 9, 2022

Thank you for all the feedback. The file has improved a lot with your reviews 🙂

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

derberg
derberg previously approved these changes Aug 17, 2022
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Barbanio excellent work!!!

Once you are back and you summarize the voting on the program, I guess you can merge 👏🏼

The next thing would be that you check with your shortlist of possible ambassadors if they are interested and then open a PR with the first ambassadors.json file (of course I will help designing it)

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Barbanio 👏 Left some suggestions.

AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
AMBASSADOR_ORGANIZATION.md Outdated Show resolved Hide resolved
@Barbanio Barbanio dismissed stale reviews from derberg and quetzalliwrites via 7be15c0 August 29, 2022 08:47
derberg
derberg previously approved these changes Aug 29, 2022
@Barbanio Barbanio requested a review from fmvilas August 29, 2022 09:12
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSC approved the program and costs -> #425

Excellent work @Barbanio 🎉

@Barbanio
Copy link
Contributor Author

/rtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants