refactor: some code smells by Sonarcloud fixes #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovebug356
requested review from
Souvikns,
magicmatatjahu,
derberg and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
lovebug356
changed the title
lovebug356
changed the title
lovebug356
force-pushed
the
sonarcloud-fixes
branch
from
7e5cb27 to
7fe04df
Compare
trx40
added a commit
to trx40/cli
that referenced
this pull request
Nov 7, 2023
Open PR asyncapi#869 already proposes this change.
lovebug356
force-pushed
the
sonarcloud-fixes
branch
from
7fe04df to
2741490
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Souvikns
approved these changes
Nov 29, 2023
|
/rtm |
|
🎉 This PR is included in version 1.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing some code smells as reported by sonarcloud
https://sonarcloud.io/summary/overall?id=asyncapi_cli