refactor: some code smells by Sonarcloud fixes (#869)

Co-authored-by: souvik <[email protected]>
asyncapi · Nov 29, 2023 · 21d782f · 21d782f
1 parent dd8ccc8
commit 21d782f
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/src/commands/generate/models.ts b/src/commands/generate/models.ts
@@ -322,15 +322,15 @@ export default class Models extends Command {
       const models = await fileGenerator.generateToFiles(
         convertedDoc as any,
         output,
-        { ...fileOptions, } as any);
+        { ...fileOptions, });
       const generatedModels = models.map((model) => { return model.modelName; });
       this.log(`Successfully generated the following models: ${generatedModels.join(', ')}`);
       return;
     }
 
     const models = await fileGenerator.generateCompleteModels(
       convertedDoc as any,
-      { ...fileOptions } as any);
+      { ...fileOptions });
     const generatedModels = models.map((model) => {
       return `
 ## Model name: ${model.modelName}

diff --git a/src/flags.ts b/src/flags.ts
@@ -4,6 +4,6 @@ export const watchFlag = (description?: string) => {
   return Flags.boolean({
     default: false,
     char: 'w',
-    description: description || 'Enable watch mode',
+    description: description ?? 'Enable watch mode',
   });
 };
diff --git a/src/globals.ts b/src/globals.ts
@@ -27,7 +27,7 @@ export type SpecWatcherParams = {
 
 export const specWatcher = (params: SpecWatcherParams) => {
   if (!params.spec.getFilePath()) { return WATCH_MESSAGES.logOnAutoDisable(params.docVersion); }
-  if (CHOKIDAR_INSTANCE_STORE.get(params.label || '_default')) { return; }
+  if (CHOKIDAR_INSTANCE_STORE.get(params.label ?? '_default')) { return; }
 
   const filePath = params.spec.getFilePath() as string;
   try {

diff --git a/src/hooks/command_not_found/myhook.ts b/src/hooks/command_not_found/myhook.ts
@@ -1,7 +1,6 @@
-import {Hook, toConfiguredId, CliUx} from '@oclif/core';
+import {Help, Hook, toConfiguredId, CliUx} from '@oclif/core';
 import chalk from 'chalk';
 import {default as levenshtein} from 'fast-levenshtein';
-import { Help } from '@oclif/core';
 
 export const closest = (target: string, possibilities: string[]): string =>
   possibilities

diff --git a/src/models/SpecificationFile.ts b/src/models/SpecificationFile.ts
@@ -64,7 +64,7 @@ export class Specification {
   }
 
   getSource() {
-    return this.getFilePath() || this.getFileURL();
+    return this.getFilePath() ?? this.getFileURL();
   }
 
   toSourceString() {