Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: studio 404 not found #332

Closed
wants to merge 2 commits into from
Closed

fix: studio 404 not found #332

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69a5147
fix: studio 404 not found
to-kr Sep 7, 2022
7d8c218
Merge branch 'master' into studio-404
derberg Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/models/Studio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,13 @@ export function start(filePath: string, port: number = DEFAULT_PORT): void {
}
});

const studioBuildFolder = existsSync(resolve(__dirname, '../../node_modules/@asyncapi/studio/build')) ?
resolve(__dirname, '../../node_modules/@asyncapi/studio/build') :
resolve(__dirname, '../../../../@asyncapi/studio/build');
Comment on lines +47 to +49
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const studioBuildFolder = existsSync(resolve(__dirname, '../../node_modules/@asyncapi/studio/build')) ?
resolve(__dirname, '../../node_modules/@asyncapi/studio/build') :
resolve(__dirname, '../../../../@asyncapi/studio/build');
const studioBuildFolder = require.resolve('@asyncapi/studio/build/index.html');

this should be universal solution. Works on my side, npm user.
wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@to-kr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@to-kr do you plan to continue with this one?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't catch your previous answer. Your solution looks good. Please fix it yourself.


const server = createServer((request, response) => {
return serveHandler(request, response, {
public: resolve(__dirname, '../../node_modules/@asyncapi/studio/build'),
public: studioBuildFolder,
});
});

Expand Down