fix: studio 404 not found #332
Conversation
to-kr
requested review from
Souvikns,
magicmatatjahu,
derberg,
boyney123 and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
@to-kr sorry for jumping into review with such delay 😞
thanks for trying to fix the issue, but I'm not 100% sure it is the best we can do. It is still kinda hacky to have hardcoded paths
could you try to use require.resolve to dynamically check where @asyncapi/studio is located?
|
Kudos, SonarCloud Quality Gate passed!
|
| const studioBuildFolder = existsSync(resolve(__dirname, '../../node_modules/@asyncapi/studio/build')) ? | ||
| resolve(__dirname, '../../node_modules/@asyncapi/studio/build') : | ||
| resolve(__dirname, '../../../../@asyncapi/studio/build'); |
There was a problem hiding this comment.
| const studioBuildFolder = existsSync(resolve(__dirname, '../../node_modules/@asyncapi/studio/build')) ? | |
| resolve(__dirname, '../../node_modules/@asyncapi/studio/build') : | |
| resolve(__dirname, '../../../../@asyncapi/studio/build'); | |
| const studioBuildFolder = require.resolve('@asyncapi/studio/build/index.html'); |
this should be universal solution. Works on my side, npm user.
wdyt?
There was a problem hiding this comment.
@to-kr do you plan to continue with this one?
There was a problem hiding this comment.
Sorry, I didn't catch your previous answer. Your solution looks good. Please fix it yourself.
|
closing in favour of #489 |
Conditional resolve of Studio Build depending on installation type.
Related issue(s)
Resolves #244