Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use npm ci and force to use npm 8 with node 18 on windows #1340

Merged
merged 15 commits into from
Apr 9, 2024
Merged

ci: use npm ci and force to use npm 8 with node 18 on windows #1340

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9c5c43a
ci: add last resort of forcing fresh installation without cache
derberg Apr 4, 2024
e0af3de
ci: remove cache usage
derberg Apr 4, 2024
c22845b
ci: more force on cache cleaning
derberg Apr 4, 2024
58f8cde
ci: enforcing bash on windows
derberg Apr 4, 2024
8d543fa
ci: time to improvize
derberg Apr 4, 2024
1e0b584
ci: use older windows
derberg Apr 4, 2024
b450ebc
dupa
derberg Apr 4, 2024
14f6fcc
well
derberg Apr 4, 2024
53952ae
refresh package-lock
derberg Apr 4, 2024
417792f
Merge branch 'master' into adadffasdfasf
Souvikns Apr 8, 2024
2977531
Merge branch 'master' into adadffasdfasf
derberg Apr 8, 2024
3692873
downgrading npm workaround
derberg Apr 9, 2024
d531c83
apply workaround to windows only
derberg Apr 9, 2024
c86cf42
Update package.json
derberg Apr 9, 2024
cbc596f
optimize to run certain steps on ubuntu only
derberg Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions .github/workflows/if-nodejs-pr-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
run: |
git config --global core.autocrlf false
git config --global core.eol lf
shell: bash
- if: steps.should_run.outputs.shouldrun == 'true'
name: Checkout repository
uses: actions/checkout@v4
Expand All @@ -56,23 +57,10 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: "${{ steps.lockversion.outputs.version }}"
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- if: steps.packagejson.outputs.exists == 'true'
name: Install dependencies
id: first-installation
shell: bash
run: npm ci
derberg marked this conversation as resolved.
Show resolved Hide resolved
continue-on-error: true
- if: steps.first-installation.outcome != 'success' && steps.packagejson.outputs.exists == 'true'
name: Clear NPM cache and install deps again
id: second-installation
run: |
npm cache clean --force
npm ci
continue-on-error: true
- if: steps.second-installation.outcome != 'success' && steps.packagejson.outputs.exists == 'true'
name: Install without cache
run: npm ci --no-cache
- if: steps.packagejson.outputs.exists == 'true'
name: Test
run: npm test --if-present
Expand All @@ -81,4 +69,4 @@ jobs:
run: npm run lint --if-present
- if: steps.packagejson.outputs.exists == 'true'
name: Run release assets generation to make sure PR does not break it
run: npm run generate:assets --if-present
run: npm run generate:assets --if-present
35 changes: 5 additions & 30 deletions .github/workflows/if-nodejs-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
run: |
git config --global core.autocrlf false
git config --global core.eol lf
shell: bash
- name: Checkout repository
uses: actions/checkout@v4
- name: Check if Node.js project and has package.json
Expand All @@ -53,23 +54,10 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: "${{ steps.lockversion.outputs.version }}"
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- if: steps.packagejson.outputs.exists == 'true'
name: Install dependencies
id: first-installation
shell: bash
run: npm ci
continue-on-error: true
- if: steps.first-installation.outcome != 'success' && steps.packagejson.outputs.exists == 'true'
name: Clear NPM cache and install deps again
id: second-installation
run: |
npm cache clean --force
npm ci
continue-on-error: true
- if: steps.second-installation.outcome != 'success' && steps.packagejson.outputs.exists == 'true'
name: Install without cache
run: npm ci --no-cache
- if: steps.packagejson.outputs.exists == 'true'
name: Run test
run: npm test --if-present
Expand All @@ -93,7 +81,7 @@ jobs:
git config --global core.autocrlf false
git config --global core.eol lf
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Check if Node.js project and has package.json
id: packagejson
run: test -e ./package.json && echo "exists=true" >> $GITHUB_OUTPUT || echo "exists=false" >> $GITHUB_OUTPUT
Expand All @@ -104,26 +92,13 @@ jobs:
id: lockversion
- if: steps.packagejson.outputs.exists == 'true'
name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: "${{ steps.lockversion.outputs.version }}"
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- if: steps.packagejson.outputs.exists == 'true'
name: Install dependencies
id: first-installation
shell: bash
run: npm ci
continue-on-error: true
- if: steps.first-installation.outcome != 'success' && steps.packagejson.outputs.exists == 'true'
name: Clear NPM cache and install deps again
id: second-installation
run: |
npm cache clean --force
npm ci
continue-on-error: true
- if: steps.second-installation.outcome != 'success' && steps.packagejson.outputs.exists == 'true'
name: Install without cache
run: npm ci --no-cache
- if: steps.packagejson.outputs.exists == 'true'
name: Add plugin for conventional commits for semantic-release
run: npm install --save-dev [email protected]
Expand Down
Loading
Loading