Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use npm ci and force to use npm 8 with node 18 on windows #1340

Merged
merged 15 commits into from
Apr 9, 2024

Conversation

derberg
Copy link
Member

@derberg derberg commented Apr 4, 2024

we need to use npm 8 when using node 18 on windows due to some cache issues

reported bug actions/runner-images#9630

even updates to package-lock did nothing

@derberg
Copy link
Member Author

derberg commented Apr 4, 2024

/ptal

@asyncapi-bot
Copy link
Contributor

@magicmatatjahu @Souvikns @asyncapi-bot-eve Please take a look at this PR. Thanks! 👋

@derberg
Copy link
Member Author

derberg commented Apr 4, 2024

/ptal

@asyncapi-bot
Copy link
Contributor

@magicmatatjahu @Souvikns Please take a look at this PR. Thanks! 👋

@derberg
Copy link
Member Author

derberg commented Apr 8, 2024

@Souvikns yeah, forcing install is scary, especially across package-lock versions

@derberg
Copy link
Member Author

derberg commented Apr 8, 2024

@Souvikns also, I tried to at least run it once, with force, to maybe manually clear the ci...but yeah,

I reported actions/runner-images#9630 last week. I see they are publishing new windows machines, so 🤞🏼

@derberg
Copy link
Member Author

derberg commented Apr 8, 2024

/help

@asyncapi-bot
Copy link
Contributor

Hello, @derberg! 👋🏼

    I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

    At the moment the following comments are supported in pull requests:

    - `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet.
    - `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
    - `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
    - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR.

@asyncapi asyncapi deleted a comment from sonarqubecloud bot Apr 8, 2024
@derberg derberg requested a review from Souvikns April 9, 2024 07:55
@derberg derberg changed the title ci: add last resort of forcing fresh installation without cache ci: use npm ci and force to use npm 8 with node 18 on windows Apr 9, 2024
Souvikns
Souvikns previously approved these changes Apr 9, 2024
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member Author

derberg commented Apr 9, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 8033891 into asyncapi:master Apr 9, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants