-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add sidebar and render examples #291
refactor: add sidebar and render examples #291
Conversation
@magicmatatjahu oh 2 features in one pr 😅
|
@derberg Thanks for review! Hah 😅 Yes 2 features, but one missed in previous PRs with examples for messages and one totally new in component with sidebar. This is last PR with "new" things, next will be focused on styling.
I removed in last commit changes from
I added tests, sorry 😅
Yep, I know, this PR (like previous) only focus on code and as you see there are 600 changed LOC. Next PRs will be focused on styling. I wanna split styling to 3 PRs: Info + Servers, Operations + Messages, Sidebar + missed parts. Could you look again? Thanks from the mountain! 🤣 |
Kudos, SonarCloud Quality Gate passed! |
PR's are welcome 😄 |
@derberg Thanks! |
🎉 This PR is included in version 0.21.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Changes proposed in this pull request:
sidebarOrganization
logic.Examples:
Related issue(s)
Part of asyncapi/shape-up-process#87
See also (fix) asyncapi/html-template#15