Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render missed parts in react-component that are showed in HTML template #87

Closed
9 tasks done
magicmatatjahu opened this issue Mar 15, 2021 · 8 comments
Closed
9 tasks done
Assignees
Labels
Epic Scope Scopes are groups of related tasks.

Comments

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Mar 15, 2021

We have list with missed parts in react-component that don't render (or render in wrong way):

Ref: #83

@magicmatatjahu magicmatatjahu added Scope Scopes are groups of related tasks. Epic labels Mar 15, 2021
@asyncapi-bot
Copy link

Hey! You've labeled this issue as a Scope. Remember you can use the following command to inform about its progress:

/progress <percentage> [message]

or

/progress <percentage>

A mutiline message.
It supports **Markdown**.
Example:
/progress 40 We're still figuring out how to implement this. We have an idea but it is not yet confirmed it will work.
/progress 50

A few notes:

* We got this figured out :tada:
* We're going to use [this library](#link-to-website) to avoid losing time implementing this algorithm.
* We decided to go for the quickest solution and will improve it if we got time at the end of the cycle.

🏋️‍♀️ See the progress on the Shape Up Dashboard.

@derberg
Copy link
Member

derberg commented Mar 15, 2021

it in general should support spec with schemas having circular refs. In other words, should work with https://github.com/asyncapi/generator/blob/master/test/docs/dummy.yml

@magicmatatjahu
Copy link
Member Author

@derberg Yes, I mentioned about it in this item It's not rendering info that schema is Circular.

@magicmatatjahu
Copy link
Member Author

/progress 40 In asyncapi/asyncapi-react#269 PR:

  • handle circular properties,
  • handle additionalItems and additionalProperties,
  • handle combined schema anyOf, allOf, and oneOf.

@magicmatatjahu
Copy link
Member Author

/progress 65 In asyncapi/asyncapi-react#276 PR:

  • render correlationId,
  • render tags,
  • render all messages, not only under the components section,

@magicmatatjahu
Copy link
Member Author

/progress 85 In asyncapi/asyncapi-react#280 PR:

  • render bindings
  • render extensions

@magicmatatjahu
Copy link
Member Author

/progress 90 Currently, the component supports everything that has been mentioned. The only thing that still needs to be added to component is the side menu/navigation.

@magicmatatjahu
Copy link
Member Author

/progress 100 Render side menu/navigation and missed examples for messages. Everything was added from HTML-Template. The skipped items will be added along with the #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Scope Scopes are groups of related tasks.
Projects
None yet
Development

No branches or pull requests

3 participants