-
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
Trying to debug the failing CI... |
…opy and switch to Travis CI for Windows builds. Also fix version comparison in build_docs.
c0d60ef
to
6ee513b
Compare
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 40.96% 41.54% +0.58%
==========================================
Files 19 19
Lines 1665 1661 -4
==========================================
+ Hits 682 690 +8
+ Misses 983 971 -12
Continue to review full report at Codecov.
|
3a9664b
to
ada30d6
Compare
166ccbc
to
31c70cd
Compare
59a277c
to
50f2fdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments @astrofrog, but nothing drastic
.travis.yml
Outdated
@@ -23,41 +22,53 @@ env: | |||
- PIP_DEPENDENCIES="codecov" | |||
- EVENT_TYPE='push pull_request' | |||
- DEBUG=True | |||
- CONDA_CHANNELS="astropy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do we install from conda that we need from the astropy channel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. could just add this to the one build that conda installs sphinx-astropy
rather than being a global setting (probably doesn't matter much, but I expect things might be slightly be faster using just the default channels)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
# Test conda's clang | ||
- os: osx | ||
env: | ||
- PYTHON_VERSION=3.5 | ||
- PYTHON_VERSION=3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need python 3.8 builds, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do that in a separate PR since that's well beyond the scope of this one :)
@@ -4,7 +4,9 @@ astropy-helpers Changelog | |||
4.0 (unreleased) | |||
------------------ | |||
|
|||
- No changes yet. | |||
- Changed minimum required Python version to 3.6. [#498] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would also mention the change in the minimum sphinx version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
""" | ||
# We've split out the Sphinx part of astropy-helpers into sphinx-astropy | ||
# but we want it to be auto-installed seamlessly for anyone using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth mentioning in the changelog that there is no more auto installing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually done in #474 for 3.2 - I'm just removing leftover comments.
Thanks @astrofrog! |
This does several things:
--parallel
option forbuild_docs