This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
Remove auto installing sphinx astropy #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 77.65% 77.15% -0.51%
==========================================
Files 11 11
Lines 1034 1033 -1
==========================================
- Hits 803 797 -6
- Misses 231 236 +5
Continue to review full report at Codecov.
|
astrofrog
reviewed
May 3, 2019
| sys_path_inserts.append(egg) | ||
| raise ImportError("sphinx-astropy is required to build documentation " | ||
| "using the astropy machinery. Please install the " | ||
| "package and try again.") |
There was a problem hiding this comment.
What about just 'sphinx-astropy needs to be installed to build the documentation' to keep it short?
|
I go ahead and merge this to tag an rc2 |
bsipocz
added a commit
that referenced
this pull request
May 3, 2019
…phinx-astropy Remove auto installing sphinx astropy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #472 and all underlying issues listed in there.
Fix #462 fix #463