Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: add missing imports for mwaa getting started docs #792

Merged
merged 1 commit into from
Jan 10, 2024
Merged

FIX: add missing imports for mwaa getting started docs #792

merged 1 commit into from
Jan 10, 2024

Conversation

Benjamin0313
Copy link
Contributor

Description

To complete this tutorial, I added two import sentence

  • import os
  • from datetime import datetime

Related Issue(s)

Nothing

Breaking Change?

Nothing

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

To complete this tutorial, I added two import sentence
- import os
- from datetime import datetime
@Benjamin0313 Benjamin0313 requested a review from a team as a code owner January 10, 2024 15:27
@Benjamin0313 Benjamin0313 requested a review from a team January 10, 2024 15:27
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 10, 2024
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
🔨 Latest commit e47ba19
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/659eb748c4a4ad000860eddd
😎 Deploy Preview https://deploy-preview-792--sunny-pastelito-5ecb04.netlify.app/getting_started/mwaa
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dosubot dosubot bot added area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality labels Jan 10, 2024
@jbandoro jbandoro changed the title FIX: add two import FIX: add missing imports for mwaa getting started docs Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05ef45d) 94.62% compared to head (e47ba19) 94.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          55       55           
  Lines        2419     2419           
=======================================
  Hits         2289     2289           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbandoro jbandoro added this to the 1.3.1 milestone Jan 10, 2024
Copy link
Collaborator

@jbandoro jbandoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @Benjamin0313 for your contributing in fixing this, much appreciated!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 10, 2024
@jbandoro jbandoro merged commit 7cdd86a into astronomer:main Jan 10, 2024
42 checks passed
tatiana added a commit that referenced this pull request Jan 10, 2024
Bug fixes

* Fix disable event tracking throwing error by @jbandoro in #784
* Fix support for string path for LoadMode.DBT_LS_FILE and docs by @Flinz in #788
* Remove stack trace to disable unnecessary K8s error by @tatiana in #790

Others

* Update examples to use the astro-runtime 10.0.0 by @RNHTTR in #777
* Docs: add missing imports for mwaa getting started by @Benjamin0313 in #792
* Refactor common executor constructors with test coverage by @jbandoro in #774
* pre-commit updates in #789
@tatiana tatiana mentioned this pull request Jan 10, 2024
tatiana added a commit that referenced this pull request Jan 11, 2024
**Bug fixes**

* Fix disable event tracking throwing error by @jbandoro in #784
* Fix support for string path for `LoadMode.DBT_LS_FILE` and docs by
@Flinz in #788
* Remove stack trace to disable unnecessary K8s error by @tatiana in
#790

**Others**

* Update examples to use the astro-runtime 10.0.0 by @RNHTTR in #777
* Docs: add missing imports for mwaa getting started by @Benjamin0313 in
#792
* Refactor common executor constructors with test coverage by @jbandoro
in #774
* pre-commit updates in #789
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
## Description

To complete this tutorial, I added two import sentence
- import os
- from datetime import datetime

## Related Issue(s)

Nothing

## Breaking Change?

Nothing

## Checklist

- [x] I have made corresponding changes to the documentation (if
required)
- [x] I have added tests that prove my fix is effective or that my
feature works
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
**Bug fixes**

* Fix disable event tracking throwing error by @jbandoro in astronomer#784
* Fix support for string path for `LoadMode.DBT_LS_FILE` and docs by
@Flinz in astronomer#788
* Remove stack trace to disable unnecessary K8s error by @tatiana in
astronomer#790

**Others**

* Update examples to use the astro-runtime 10.0.0 by @RNHTTR in astronomer#777
* Docs: add missing imports for mwaa getting started by @Benjamin0313 in
astronomer#792
* Refactor common executor constructors with test coverage by @jbandoro
in astronomer#774
* pre-commit updates in astronomer#789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants