Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs and path for ls file (#773) #788

Merged

Conversation

seeholza
Copy link
Contributor

@seeholza seeholza commented Jan 8, 2024

Description

fix docs and support str argument for dbt_ls_file

Related Issue(s)

closes #773

Breaking Change?

No

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

* Update config.py to include docs for dbt_ls_path and support Path and str
* Update parsing-methods.rst to fix typo on DBT_LS_FILE
@seeholza seeholza requested a review from a team as a code owner January 8, 2024 14:21
@seeholza seeholza requested a review from a team January 8, 2024 14:21
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 8, 2024
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit c69e0c7
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/659c1e695ba24d0008db6462

@dosubot dosubot bot added area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality execution:local Related to Local execution environment parsing:dbt_ls Issues, questions, or features related to dbt_ls parsing labels Jan 8, 2024
@seeholza seeholza changed the title 773 fix docs and path for ls file (#1) fix docs and path for ls file (#773) Jan 8, 2024
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing the docs, @Flinz !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (380ac52) 94.62% compared to head (c69e0c7) 94.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #788   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          55       55           
  Lines        2419     2420    +1     
=======================================
+ Hits         2289     2290    +1     
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 8, 2024
@tatiana tatiana merged commit 955aa1c into astronomer:main Jan 9, 2024
42 checks passed
@tatiana tatiana added this to the 1.3.1 milestone Jan 9, 2024
tatiana added a commit that referenced this pull request Jan 10, 2024
Bug fixes

* Fix disable event tracking throwing error by @jbandoro in #784
* Fix support for string path for LoadMode.DBT_LS_FILE and docs by @Flinz in #788
* Remove stack trace to disable unnecessary K8s error by @tatiana in #790

Others

* Update examples to use the astro-runtime 10.0.0 by @RNHTTR in #777
* Docs: add missing imports for mwaa getting started by @Benjamin0313 in #792
* Refactor common executor constructors with test coverage by @jbandoro in #774
* pre-commit updates in #789
@tatiana tatiana mentioned this pull request Jan 10, 2024
tatiana added a commit that referenced this pull request Jan 11, 2024
**Bug fixes**

* Fix disable event tracking throwing error by @jbandoro in #784
* Fix support for string path for `LoadMode.DBT_LS_FILE` and docs by
@Flinz in #788
* Remove stack trace to disable unnecessary K8s error by @tatiana in
#790

**Others**

* Update examples to use the astro-runtime 10.0.0 by @RNHTTR in #777
* Docs: add missing imports for mwaa getting started by @Benjamin0313 in
#792
* Refactor common executor constructors with test coverage by @jbandoro
in #774
* pre-commit updates in #789
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
Fix docs and support str argument for `dbt_ls_file`

Closes: astronomer#773 

Co-authored-by: Alex Seeholzer <[email protected]>
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this pull request Jul 14, 2024
**Bug fixes**

* Fix disable event tracking throwing error by @jbandoro in astronomer#784
* Fix support for string path for `LoadMode.DBT_LS_FILE` and docs by
@Flinz in astronomer#788
* Remove stack trace to disable unnecessary K8s error by @tatiana in
astronomer#790

**Others**

* Update examples to use the astro-runtime 10.0.0 by @RNHTTR in astronomer#777
* Docs: add missing imports for mwaa getting started by @Benjamin0313 in
astronomer#792
* Refactor common executor constructors with test coverage by @jbandoro
in astronomer#774
* pre-commit updates in astronomer#789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality execution:local Related to Local execution environment lgtm This PR has been approved by a maintainer parsing:dbt_ls Issues, questions, or features related to dbt_ls parsing size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt_ls_path: wrong docs and argument should support both Path and str types
3 participants