-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docs and path for ls file (#773) #788
Merged
tatiana
merged 2 commits into
astronomer:main
from
seeholza:773_fix_docs_and_path_for_ls_file_squashed
Jan 9, 2024
Merged
fix docs and path for ls file (#773) #788
tatiana
merged 2 commits into
astronomer:main
from
seeholza:773_fix_docs_and_path_for_ls_file_squashed
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update config.py to include docs for dbt_ls_path and support Path and str * Update parsing-methods.rst to fix typo on DBT_LS_FILE
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Jan 8, 2024
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
dosubot
bot
added
area:docs
Relating to documentation, changes, fixes, improvement
dbt:docs
Primarily related to dbt docs command or functionality
execution:local
Related to Local execution environment
parsing:dbt_ls
Issues, questions, or features related to dbt_ls parsing
labels
Jan 8, 2024
seeholza
changed the title
773 fix docs and path for ls file (#1)
fix docs and path for ls file (#773)
Jan 8, 2024
tatiana
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for fixing the docs, @Flinz !
tatiana
reviewed
Jan 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 55 55
Lines 2419 2420 +1
=======================================
+ Hits 2289 2290 +1
Misses 130 130 ☔ View full report in Codecov by Sentry. |
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Jan 8, 2024
tatiana
added a commit
that referenced
this pull request
Jan 10, 2024
Bug fixes * Fix disable event tracking throwing error by @jbandoro in #784 * Fix support for string path for LoadMode.DBT_LS_FILE and docs by @Flinz in #788 * Remove stack trace to disable unnecessary K8s error by @tatiana in #790 Others * Update examples to use the astro-runtime 10.0.0 by @RNHTTR in #777 * Docs: add missing imports for mwaa getting started by @Benjamin0313 in #792 * Refactor common executor constructors with test coverage by @jbandoro in #774 * pre-commit updates in #789
Merged
tatiana
added a commit
that referenced
this pull request
Jan 11, 2024
**Bug fixes** * Fix disable event tracking throwing error by @jbandoro in #784 * Fix support for string path for `LoadMode.DBT_LS_FILE` and docs by @Flinz in #788 * Remove stack trace to disable unnecessary K8s error by @tatiana in #790 **Others** * Update examples to use the astro-runtime 10.0.0 by @RNHTTR in #777 * Docs: add missing imports for mwaa getting started by @Benjamin0313 in #792 * Refactor common executor constructors with test coverage by @jbandoro in #774 * pre-commit updates in #789
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
Fix docs and support str argument for `dbt_ls_file` Closes: astronomer#773 Co-authored-by: Alex Seeholzer <[email protected]>
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
**Bug fixes** * Fix disable event tracking throwing error by @jbandoro in astronomer#784 * Fix support for string path for `LoadMode.DBT_LS_FILE` and docs by @Flinz in astronomer#788 * Remove stack trace to disable unnecessary K8s error by @tatiana in astronomer#790 **Others** * Update examples to use the astro-runtime 10.0.0 by @RNHTTR in astronomer#777 * Docs: add missing imports for mwaa getting started by @Benjamin0313 in astronomer#792 * Refactor common executor constructors with test coverage by @jbandoro in astronomer#774 * pre-commit updates in astronomer#789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Relating to documentation, changes, fixes, improvement
dbt:docs
Primarily related to dbt docs command or functionality
execution:local
Related to Local execution environment
lgtm
This PR has been approved by a maintainer
parsing:dbt_ls
Issues, questions, or features related to dbt_ls parsing
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix docs and support str argument for dbt_ls_file
Related Issue(s)
closes #773
Breaking Change?
No
Checklist