Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable test for Airflow-2.5 and Python-3.11 combination #1124

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Jul 29, 2024

Description

We noticed in PR #1107 that tests are failing with errors

    TIMEZONE = pendulum.tz.timezone("UTC")
E   TypeError: 'module' object is not callable

Found that this is happening because pendulum upgrade and CI is not using the constraints file.
This PR disabled the test for Airflow2.5 and Python3.11 combination because constraints does not exist this.

CI Job success: https://github.com/astronomer/astronomer-cosmos/actions/runs/10139381920
CI Job failure: https://github.com/astronomer/astronomer-cosmos/actions/runs/10136915016/
Airflow 2.5 constraints: https://github.com/apache/airflow/tree/constraints-2-5

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit f50734f
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/66a748fe8b0c6500085aa6e3

@pankajastro pankajastro changed the title Add a debug todo for ci test [Testing] Add a debug todo for ci test Jul 29, 2024
@pankajastro pankajastro changed the title [Testing] Add a debug todo for ci test [CI] Disable test for Airflow-2.5 and Python-3.11 combination Jul 29, 2024
@pankajastro pankajastro marked this pull request as ready for review July 29, 2024 07:47
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 29, 2024
@dosubot dosubot bot added the area:ci Related to CI, Github Actions, or other continuous integration tools label Jul 29, 2024
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, @pankajastro , pre-approving. Feel free to merge once the tests are passing

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
@pankajastro
Copy link
Contributor Author

pankajastro commented Jul 29, 2024

the tests are failing because CI is using the workflow from the main branch. CI run on this branch https://github.com/astronomer/astronomer-cosmos/actions/runs/10139381920

@pankajastro
Copy link
Contributor Author

pankajastro commented Jul 29, 2024

Merging it. The CI failure is because CI uses config from the main branch. We need this to fix CI for #1107

@pankajastro pankajastro merged commit bbec5d8 into main Jul 29, 2024
18 of 62 checks passed
@pankajastro pankajastro deleted the fix_ci branch July 29, 2024 08:22
@pankajkoti pankajkoti mentioned this pull request Jul 31, 2024
dwreeves pushed a commit to dwreeves/astronomer-cosmos that referenced this pull request Jul 31, 2024
…omer#1124)

## Description
We noticed in PR
astronomer#1107 that tests are
failing with errors
```
    TIMEZONE = pendulum.tz.timezone("UTC")
E   TypeError: 'module' object is not callable
```
Found that this is happening because pendulum upgrade and CI is not
using the constraints file.
This PR disabled the test for Airflow2.5 and Python3.11 combination
because constraints does not exist this.

CI Job success:
https://github.com/astronomer/astronomer-cosmos/actions/runs/10139381920
CI Job failure:
https://github.com/astronomer/astronomer-cosmos/actions/runs/10136915016/
Airflow 2.5 constraints:
https://github.com/apache/airflow/tree/constraints-2-5


## Checklist

- [ ] I have made corresponding changes to the documentation (if
required)
- [ ] I have added tests that prove my fix is effective or that my
feature works
pankajkoti added a commit that referenced this pull request Aug 20, 2024
New Features

* Add support for loading manifest from cloud stores using Airflow
Object Storage by @pankajkoti in #1109
* Cache ``package-lock.yml`` file by @pankajastro in #1086
* Support persisting the ``LoadMode.VIRTUALENV`` directory by @tatiana
in #1079
* Add support to store and fetch ``dbt ls`` cache in remote stores by
@pankajkoti in #1147
* Add default source nodes rendering by @arojasb3 in #1107
* Add Teradata ``ProfileMapping`` by @sc250072 in #1077

Enhancements

* Add ``DatabricksOauthProfileMapping`` profile by @CorsettiS in #1091
* Use ``dbt ls`` as the default parser when ``profile_config`` is
provided by @pankajastro in #1101
* Add task owner to dbt operators by @wornjs in #1082
* Extend Cosmos custom selector to support + when using paths and tags
by @mvictoria in #1150
* Simplify logging by @dwreeves in #1108

Bug fixes

* Fix Teradata ``ProfileMapping`` target invalid issue by @sc250072 in
#1088
* Fix empty tag in case of custom parser by @pankajastro in #1100
* Fix ``dbt deps`` of ``LoadMode.DBT_LS`` should use
``ProjectConfig.dbt_vars`` by @tatiana in #1114
* Fix import handling by lazy loading hooks introduced in PR #1109 by
@dwreeves in #1132
* Fix Airflow 2.10 regression and add Airflow 2.10 in test matrix by
@pankajastro in #1162

Docs

* Fix typo in azure-container-instance docs by @pankajastro in #1106
* Use Airflow trademark as it has been registered by @pankajastro in
#1105

Others

* Run some example DAGs in Kubernetes execution mode in CI by
@pankajastro in #1127
* Install requirements.txt by default during dev env spin up by
@@CorsettiS in #1099
* Remove ``DbtGraph.current_version`` dead code by @tatiana in #1111
* Disable test for Airflow-2.5 and Python-3.11 combination in CI by
@pankajastro in #1124
* Pre-commit hook updates in #1074, #1113, #1125, #1144, #1154,  #1167

---------

Co-authored-by: Pankaj Koti <[email protected]>
Co-authored-by: Pankaj Singh <[email protected]>
@tatiana tatiana added this to the Cosmos 1.6.1 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Related to CI, Github Actions, or other continuous integration tools lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants