-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Airflow trademark as it has been registered #1105
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
+ Coverage 96.24% 96.25% +0.01%
==========================================
Files 63 64 +1
Lines 3273 3287 +14
==========================================
+ Hits 3150 3164 +14
Misses 123 123 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it also a requirement that we need to add a link back to the Apache Airflow page?
Yes, it is required. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pankajastro I'm unsure about this change, I think there is a high likelihood we'll forget adding this symbol after every mention to Apache Airflow.
Also, dbt is equally registered as a trademark: https://www.getdbt.com/assets/docs/dbtTrademarkGuidelines.pdf
And probably other technologies we're mentioning in the docs as well, including Databricks and Snowflake. Is this change really necessary?
I checked the dbt trademark guidelines, and the documentation advises using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pankajastro I'm unsure about this change, I think there is a high likelihood we'll forget adding this symbol after every mention to Apache Airflow.
Also, dbt is equally registered as a trademark: https://www.getdbt.com/assets/docs/dbtTrademarkGuidelines.pdf
And probably other technologies we're mentioning in the docs as well, including Databricks and Snowflake. Is this change really necessary?I checked the dbt trademark guidelines, and the documentation advises using
dbt™
. Does this mean it is not a registered trademark? I couldn't find any sources for Databricks and Snowflake that provide guidelines on how to use their names correctly.
@pankajastro Fair enough, let's make our docs compliant with Apache Airflow® - this is the scope of this PR - and when we learn more about the other projects, we can update the docs. Thanks a lot for checking this, @pankajastro !
## Description Replace "Apache Airflow" with "Apache Airflow®" Airflow Dev mailing list: https://lists.apache.org/thread/0fmp9olljfkm3vmg3ns5qd1o95sm7235#:~:text=Hello%20Airflow%20community%2C%20The%20PMC,later%2C%20ASF%20got%20the%20trademark.
New Features * Add support for loading manifest from cloud stores using Airflow Object Storage by @pankajkoti in #1109 * Cache ``package-lock.yml`` file by @pankajastro in #1086 * Support persisting the ``LoadMode.VIRTUALENV`` directory by @tatiana in #1079 * Add support to store and fetch ``dbt ls`` cache in remote stores by @pankajkoti in #1147 * Add default source nodes rendering by @arojasb3 in #1107 * Add Teradata ``ProfileMapping`` by @sc250072 in #1077 Enhancements * Add ``DatabricksOauthProfileMapping`` profile by @CorsettiS in #1091 * Use ``dbt ls`` as the default parser when ``profile_config`` is provided by @pankajastro in #1101 * Add task owner to dbt operators by @wornjs in #1082 * Extend Cosmos custom selector to support + when using paths and tags by @mvictoria in #1150 * Simplify logging by @dwreeves in #1108 Bug fixes * Fix Teradata ``ProfileMapping`` target invalid issue by @sc250072 in #1088 * Fix empty tag in case of custom parser by @pankajastro in #1100 * Fix ``dbt deps`` of ``LoadMode.DBT_LS`` should use ``ProjectConfig.dbt_vars`` by @tatiana in #1114 * Fix import handling by lazy loading hooks introduced in PR #1109 by @dwreeves in #1132 * Fix Airflow 2.10 regression and add Airflow 2.10 in test matrix by @pankajastro in #1162 Docs * Fix typo in azure-container-instance docs by @pankajastro in #1106 * Use Airflow trademark as it has been registered by @pankajastro in #1105 Others * Run some example DAGs in Kubernetes execution mode in CI by @pankajastro in #1127 * Install requirements.txt by default during dev env spin up by @@CorsettiS in #1099 * Remove ``DbtGraph.current_version`` dead code by @tatiana in #1111 * Disable test for Airflow-2.5 and Python-3.11 combination in CI by @pankajastro in #1124 * Pre-commit hook updates in #1074, #1113, #1125, #1144, #1154, #1167 --------- Co-authored-by: Pankaj Koti <[email protected]> Co-authored-by: Pankaj Singh <[email protected]>
Description
Replace "Apache Airflow" with "Apache Airflow®"
Airflow Dev mailing list: https://lists.apache.org/thread/0fmp9olljfkm3vmg3ns5qd1o95sm7235#:~:text=Hello%20Airflow%20community%2C%20The%20PMC,later%2C%20ASF%20got%20the%20trademark.