Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Airflow trademark as it has been registered #1105

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Jul 18, 2024

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 18, 2024
Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for sunny-pastelito-5ecb04 ready!

Name Link
🔨 Latest commit 769ab96
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/6699588ea6bc400008a4d8b2
😎 Deploy Preview https://deploy-preview-1105--sunny-pastelito-5ecb04.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dosubot dosubot bot added the area:docs Relating to documentation, changes, fixes, improvement label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (87b2b14) to head (769ab96).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
+ Coverage   96.24%   96.25%   +0.01%     
==========================================
  Files          63       64       +1     
  Lines        3273     3287      +14     
==========================================
+ Hits         3150     3164      +14     
  Misses        123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it also a requirement that we need to add a link back to the Apache Airflow page?

docs/getting_started/docker.rst Outdated Show resolved Hide resolved
@pankajastro
Copy link
Contributor Author

Is it also a requirement that we need to add a link back to the Apache Airflow page?

Yes, it is required. Thank you!

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankajastro I'm unsure about this change, I think there is a high likelihood we'll forget adding this symbol after every mention to Apache Airflow.

Also, dbt is equally registered as a trademark: https://www.getdbt.com/assets/docs/dbtTrademarkGuidelines.pdf

And probably other technologies we're mentioning in the docs as well, including Databricks and Snowflake. Is this change really necessary?

@pankajastro
Copy link
Contributor Author

@pankajastro I'm unsure about this change, I think there is a high likelihood we'll forget adding this symbol after every mention to Apache Airflow.

Also, dbt is equally registered as a trademark: https://www.getdbt.com/assets/docs/dbtTrademarkGuidelines.pdf

And probably other technologies we're mentioning in the docs as well, including Databricks and Snowflake. Is this change really necessary?

I checked the dbt trademark guidelines, and the documentation advises using dbt™. Does this mean it is not a registered trademark?
I couldn't find any sources for Databricks and Snowflake that provide guidelines on how to use their names correctly.

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankajastro I'm unsure about this change, I think there is a high likelihood we'll forget adding this symbol after every mention to Apache Airflow.
Also, dbt is equally registered as a trademark: https://www.getdbt.com/assets/docs/dbtTrademarkGuidelines.pdf
And probably other technologies we're mentioning in the docs as well, including Databricks and Snowflake. Is this change really necessary?

I checked the dbt trademark guidelines, and the documentation advises using dbt™. Does this mean it is not a registered trademark? I couldn't find any sources for Databricks and Snowflake that provide guidelines on how to use their names correctly.

@pankajastro Fair enough, let's make our docs compliant with Apache Airflow® - this is the scope of this PR - and when we learn more about the other projects, we can update the docs. Thanks a lot for checking this, @pankajastro !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2024
@pankajastro pankajastro merged commit 89a8034 into main Jul 24, 2024
64 checks passed
@pankajastro pankajastro deleted the airflow-trademark branch July 24, 2024 05:05
@pankajkoti pankajkoti mentioned this pull request Jul 31, 2024
dwreeves pushed a commit to dwreeves/astronomer-cosmos that referenced this pull request Jul 31, 2024
pankajkoti added a commit that referenced this pull request Aug 20, 2024
New Features

* Add support for loading manifest from cloud stores using Airflow
Object Storage by @pankajkoti in #1109
* Cache ``package-lock.yml`` file by @pankajastro in #1086
* Support persisting the ``LoadMode.VIRTUALENV`` directory by @tatiana
in #1079
* Add support to store and fetch ``dbt ls`` cache in remote stores by
@pankajkoti in #1147
* Add default source nodes rendering by @arojasb3 in #1107
* Add Teradata ``ProfileMapping`` by @sc250072 in #1077

Enhancements

* Add ``DatabricksOauthProfileMapping`` profile by @CorsettiS in #1091
* Use ``dbt ls`` as the default parser when ``profile_config`` is
provided by @pankajastro in #1101
* Add task owner to dbt operators by @wornjs in #1082
* Extend Cosmos custom selector to support + when using paths and tags
by @mvictoria in #1150
* Simplify logging by @dwreeves in #1108

Bug fixes

* Fix Teradata ``ProfileMapping`` target invalid issue by @sc250072 in
#1088
* Fix empty tag in case of custom parser by @pankajastro in #1100
* Fix ``dbt deps`` of ``LoadMode.DBT_LS`` should use
``ProjectConfig.dbt_vars`` by @tatiana in #1114
* Fix import handling by lazy loading hooks introduced in PR #1109 by
@dwreeves in #1132
* Fix Airflow 2.10 regression and add Airflow 2.10 in test matrix by
@pankajastro in #1162

Docs

* Fix typo in azure-container-instance docs by @pankajastro in #1106
* Use Airflow trademark as it has been registered by @pankajastro in
#1105

Others

* Run some example DAGs in Kubernetes execution mode in CI by
@pankajastro in #1127
* Install requirements.txt by default during dev env spin up by
@@CorsettiS in #1099
* Remove ``DbtGraph.current_version`` dead code by @tatiana in #1111
* Disable test for Airflow-2.5 and Python-3.11 combination in CI by
@pankajastro in #1124
* Pre-commit hook updates in #1074, #1113, #1125, #1144, #1154,  #1167

---------

Co-authored-by: Pankaj Koti <[email protected]>
Co-authored-by: Pankaj Singh <[email protected]>
@tatiana tatiana added this to the Cosmos 1.6.1 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Relating to documentation, changes, fixes, improvement lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants