-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement transfer for GCS/S3 to BigQuery #1794
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…tronomer/astro-sdk into SnowflakeDatabaseDataProvider
rajaths010494
changed the title
Implement transfer for GCS/s3 to BigQuery
Implement transfer for GCS/S3 to BigQuery
Feb 23, 2023
rajaths010494
changed the base branch from
main
to
SnowflakeDatabaseDataProvider
February 23, 2023 10:20
dimberman
requested changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! few nit comments but looking good overall.
...transfer_operator/src/universal_transfer_operator/data_providers/database/google/bigquery.py
Outdated
Show resolved
Hide resolved
...transfer_operator/src/universal_transfer_operator/data_providers/database/google/bigquery.py
Show resolved
Hide resolved
...transfer_operator/src/universal_transfer_operator/data_providers/database/google/bigquery.py
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
…astro-sdk into bigquweydataprovider
Added read operations for bigquery as well. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
2 tasks
utkarsharma2
force-pushed
the
SnowflakeDatabaseDataProvider
branch
2 times, most recently
from
March 2, 2023 15:58
14b9fb4
to
275608e
Compare
closing this as this PR #1829 will cover along with tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the feature you'd like to see
DataProvider
for Bigquery - read/write methodsAcceptance Criteria