Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test coverage #191

Closed
tatiana opened this issue Mar 10, 2022 · 0 comments · Fixed by #203
Closed

Enable test coverage #191

tatiana opened this issue Mar 10, 2022 · 0 comments · Fixed by #203
Assignees
@dimberman
Labels
priority/high High priority testing Unit or integration testing improvements

Comments

@tatiana
Copy link
Collaborator

tatiana commented Mar 10, 2022 •
edited by dimberman
Loading

Description

To improve the testing health of the project, we will add a codecov integration s.t. all PRs with passing tests will recieve a codecov report. We will also fail any PR where code coverage goes down more than 2%.

Acceptance criteria

  • Users should have the ability to locally run a code coverage plugin to get reports without submitting to CI
  • CI should automatically generate a code coverage report when users submit a PR with passing tests
  • As part of the pull request, evaluate the coverage and fail if the coverage goes down by more than -2%
  • Enable code-cov on the Github repo
@dimberman dimberman self-assigned this Mar 10, 2022
@dimberman dimberman added priority/high High priority testing Unit or integration testing improvements labels Mar 10, 2022
@tatiana tatiana mentioned this issue Mar 12, 2022
Merged
4 tasks
@tatiana tatiana mentioned this issue Mar 23, 2022
Closed
12 tasks
@mikeshwe mikeshwe mentioned this issue May 17, 2022
Closed
9 tasks
This was referenced Jun 21, 2022
Open
Closed
@fritz-astronomer fritz-astronomer mentioned this issue Jun 22, 2022
Closed
9 tasks
This was referenced Jun 28, 2022
Closed
Closed
Closed
@utkarsharma2 utkarsharma2 mentioned this issue Jun 30, 2022
Closed
6 tasks
@phanikumv phanikumv mentioned this issue Jul 6, 2022
Closed
9 tasks
This was referenced Jul 6, 2022
Closed
Closed
@utkarsharma2 utkarsharma2 mentioned this issue Jul 13, 2022
Closed
9 tasks
@sunank200 sunank200 mentioned this issue Jul 19, 2022
Closed
10 tasks
@dimberman dimberman mentioned this issue Jul 25, 2022
Closed
11 tasks
@utkarsharma2 utkarsharma2 mentioned this issue Jul 26, 2022
Closed
9 tasks
This was referenced Jul 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@rajaths010494 rajaths010494 mentioned this issue Feb 24, 2023
Open
9 tasks
@phanikumv phanikumv mentioned this issue Feb 27, 2023
Open
9 tasks
This was referenced Feb 28, 2023
Open
Open
This was referenced Mar 3, 2023
Closed
Open
Open
Open
Open
@rajaths010494 rajaths010494 mentioned this issue Mar 6, 2023
Merged
9 tasks
@utkarsharma2 utkarsharma2 mentioned this issue Mar 10, 2023
Closed
9 tasks
utkarsharma2 added a commit that referenced this issue Mar 16, 2023
@rajaths010494 @pre-commit-ci
@utkarsharma2 @phanikumv
Implement transfer for BigQuery - read/write (#1829)
d06d3e7 
**Please describe the feature you'd like to see**
- Add `DataProvider` for Bigquery - read/write methods
- Add non-native transfer implementation for GCS to BigQuery
-  Add non-native transfer implementation for S3 to BigQuery
- Add non-native transfer example DAG for BigQuery to Sqlite 
- Add non-native transfer example DAG for BigQuery to Snowflake
- Add example DAG
- Add tests with 90% coverage

**Acceptance Criteria**

- [ ] All checks and tests in the CI should pass
- [ ] Unit tests (90% code coverage or more, [once
available](#191))
- [ ] Integration tests (if the feature relates to a new database or
external service)
- [ ] Example DAG
- [ ] Docstrings in
[reStructuredText](https://peps.python.org/pep-0287/) for each of
methods, classes, functions and module-level attributes (including
Example DAG on how it should be used)
- [ ] Exception handling in case of errors
- [ ] Logging (are we exposing useful information to the user? e.g.
source and destination)
- [ ] Improve the documentation (README, Sphinx, and any other relevant)
- [ ] How to use Guide for the feature
([example](https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/operators/postgres_operator_howto_guide.html))


closes: #1732 
closes: #1785
closes: #1730

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Utkarsh Sharma <[email protected]>
Co-authored-by: Phani Kumar <[email protected]>
@rajaths010494 rajaths010494 mentioned this issue Mar 17, 2023
Closed
9 tasks
@utkarsharma2 utkarsharma2 mentioned this issue Mar 17, 2023
Closed
9 tasks
@dimberman dimberman mentioned this issue Mar 19, 2023
Open
9 tasks
@rajaths010494 rajaths010494 mentioned this issue Mar 21, 2023
Closed
9 tasks
This was referenced Mar 27, 2023
Open
Open
sunank200 pushed a commit to astronomer/apache-airflow-providers-transfers that referenced this issue Mar 24, 2023
@rajaths010494 @pre-commit-ci
@utkarsharma2 @phanikumv
Implement transfer for BigQuery - read/write (#1829)
32afcef 
**Please describe the feature you'd like to see**
- Add `DataProvider` for Bigquery - read/write methods
- Add non-native transfer implementation for GCS to BigQuery
-  Add non-native transfer implementation for S3 to BigQuery
- Add non-native transfer example DAG for BigQuery to Sqlite 
- Add non-native transfer example DAG for BigQuery to Snowflake
- Add example DAG
- Add tests with 90% coverage

**Acceptance Criteria**

- [ ] All checks and tests in the CI should pass
- [ ] Unit tests (90% code coverage or more, [once
available](astronomer/astro-sdk#191))
- [ ] Integration tests (if the feature relates to a new database or
external service)
- [ ] Example DAG
- [ ] Docstrings in
[reStructuredText](https://peps.python.org/pep-0287/) for each of
methods, classes, functions and module-level attributes (including
Example DAG on how it should be used)
- [ ] Exception handling in case of errors
- [ ] Logging (are we exposing useful information to the user? e.g.
source and destination)
- [ ] Improve the documentation (README, Sphinx, and any other relevant)
- [ ] How to use Guide for the feature
([example](https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/operators/postgres_operator_howto_guide.html))


closes: #1732 
closes: astronomer/astro-sdk#1785
closes: astronomer/astro-sdk#1730

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Utkarsh Sharma <[email protected]>
Co-authored-by: Phani Kumar <[email protected]>
@utkarsharma2 utkarsharma2 mentioned this issue Mar 28, 2023
Open
9 tasks
@phanikumv phanikumv mentioned this issue Apr 10, 2023
Open
9 tasks
@pankajkoti pankajkoti mentioned this issue Apr 24, 2023
Open
9 tasks
@phanikumv phanikumv mentioned this issue Apr 25, 2023
Open
9 tasks
@tatiana tatiana mentioned this issue May 5, 2023
Closed
6 tasks
@ianbuss ianbuss mentioned this issue May 25, 2023
Open
9 tasks
@skolchin skolchin mentioned this issue Jun 4, 2023
Closed
9 tasks
@Andrew-Wichmann Andrew-Wichmann mentioned this issue Jul 8, 2023
Closed
9 tasks
@Andrew-Wichmann Andrew-Wichmann mentioned this issue Dec 23, 2023
Open
9 tasks
@adam-phillipps adam-phillipps mentioned this issue Mar 27, 2024
Open
9 tasks
@1cadumagalhaes 1cadumagalhaes mentioned this issue May 3, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimberman dimberman

Labels
priority/high High priority testing Unit or integration testing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add codecov coverage report astronomer/astro-sdk
2 participants
@tatiana @dimberman