[ruff] Stabilize useless-if-else (RUF034)
#15351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF034 | 2 | 2 | 0 | 0 | 0 |
| PYI006 | 1 | 1 | 0 | 0 | 0 |
| PLR1716 | 1 | 1 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+0 -4 violations, +0 -0 fixes in 2 projects; 53 projects unchanged)
apache/airflow (+0 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL
- airflow/decorators/condition.py:32:35: TC008 [*] Remove quotes from type alias - airflow/decorators/condition.py:33:35: TC008 [*] Remove quotes from type alias
latchbio/latch (+0 -2 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview
- src/latch/ldata/_transfer/upload.py:30:32: TC008 [*] Remove quotes from type alias - src/latch/ldata/_transfer/upload.py:31:35: TC008 [*] Remove quotes from type alias
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| TC008 | 4 | 0 | 4 | 0 | 0 |
MichaReiser
changed the title
RUF] Stabilize useless-if-else (RUF034)ruff] Stabilize useless-if-else (RUF034)
AlexWaygood
approved these changes
Jan 8, 2025
MichaReiser
force-pushed
the
micha/useless-if-else
branch
from
c2917f2 to
7538099
Compare
MichaReiser
added a commit
that referenced
this pull request
Jan 8, 2025
MichaReiser
added a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize
useless-if-elseI'm somewhat torn on the name:
if-expr->useless-if-expr?Clippy's name for the same rule is
if_same_then_elsewhich I like better because it doesn't suggest that it is useless. However, I fail to come up to address my first concern becauseif-expr-if-same-then-elsesounds off but maybe it's fine?Test Plan
There are no open issues for this rule.
The ecosystem changes look correct to me