[ruff] Stabilize useless-if-else (RUF034) (#15351)

astral-sh · Jan 9, 2025 · 29f6653 · 29f6653
1 parent d645525
commit 29f6653
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/crates/ruff_linter/src/codes.rs b/crates/ruff_linter/src/codes.rs
@@ -982,7 +982,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Ruff, "031") => (RuleGroup::Preview, rules::ruff::rules::IncorrectlyParenthesizedTupleInSubscript),
         (Ruff, "032") => (RuleGroup::Stable, rules::ruff::rules::DecimalFromFloatLiteral),
         (Ruff, "033") => (RuleGroup::Stable, rules::ruff::rules::PostInitDefault),
-        (Ruff, "034") => (RuleGroup::Preview, rules::ruff::rules::UselessIfElse),
+        (Ruff, "034") => (RuleGroup::Stable, rules::ruff::rules::UselessIfElse),
         (Ruff, "035") => (RuleGroup::Preview, rules::ruff::rules::UnsafeMarkupUse),
         (Ruff, "036") => (RuleGroup::Preview, rules::ruff::rules::NoneNotAtEndOfUnion),
         (Ruff, "037") => (RuleGroup::Preview, rules::ruff::rules::UnnecessaryEmptyIterableWithinDequeCall),

diff --git a/crates/ruff_linter/src/rules/ruff/rules/useless_if_else.rs b/crates/ruff_linter/src/rules/ruff/rules/useless_if_else.rs
@@ -9,20 +9,15 @@ use ruff_python_ast::comparable::ComparableExpr;
 ///
 /// ## Why is this bad?
 /// Useless `if`-`else` conditions add unnecessary complexity to the code without
-/// providing any logical benefit.
-///
-/// Assigning the value directly is clearer and more explicit, and
-/// should be preferred.
+/// providing any logical benefit. Assigning the value directly is clearer.
 ///
 /// ## Example
 /// ```python
-/// # Bad
 /// foo = x if y else x
 /// ```
 ///
 /// Use instead:
 /// ```python
-/// # Good
 /// foo = x
 /// ```
 #[derive(ViolationMetadata)]