[flake8-use-pathlib] Extend check for invalid path suffix to include the case "." (PTH210)

[TheBits]

Summary

Hi!

Thank you @InSyncWithFoo for the your contribution #14779!

I suggest adding a test that makes use of the suffix='.'. It must fail. Right now, ruff doesn't show any errors in this test.

Test Plan

Tests fails

[dylwil3]

Thanks for suggesting this test and pointing out the bug! Of course, since it fails we can't merge it in without also having the fix 😄 Would you be interested in taking a look and fleshing out your PR? I believe this early return needs to be modified:

ruff/crates/ruff_linter/src/rules/flake8_use_pathlib/rules/dotless_pathlib_with_suffix.rs

Lines 78 to 80 in d4126f6

	if string_value.is_empty() || string_value.starts_with('.') {
	return;
	}

Edit: Actually the change will be a little more involved because I don't think it makes sense to offer a fix in this case, so you'll have to change the rule to be only sometimes fixable. Let me know if you're interested and/or need any pointers navigating that change.

[InSyncWithFoo]

The rule, which is currently called dotless-pathlib-with-suffix, might also need to be renamed. Its documentation requires an update as well.

[github-actions]

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

[TheBits]

@dylwil3 Yes, I need help. I tried to figure it out and fix the dotless_pathlib_with_suffix. Have I made the appropriate corrections?

[MichaReiser]

The rule, which is currently called _dotless_-pathlib-with-suffix, might also need to be renamed. Its documentation requires an update as well.

Agree, we should probably rename it to invalid-pathlib-with-suffix or similar.

[dylwil3]

Looking good! In addition to Micha's suggestions, could you update the documentation comment?

[dylwil3]

We may want to add a TODO comment for when Python 3.14 is released/supported by Ruff. The rule should revert to the original behavior in that case since "." is a valid suffix in 3.14.

[TheBits]

Looking good! In addition to Micha's suggestions, could you update the documentation comment?

Thanks! I will try to update documentation comment.

[dylwil3]

Few more nits - almost there!

[dylwil3]

LGTM! Thanks so much for your patience, and for the great contribution!